linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>, Shawn Guo <shawnguo@kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 bus+gpio 3/5] bus: moxtet: Add sysfs documentation
Date: Fri, 1 Mar 2019 16:15:10 +0100	[thread overview]
Message-ID: <20190301161510.20b15183@nic.cz> (raw)
In-Reply-To: <CACRpkdam_CYGtph16McpQQ_WwohpZr+Rzi1B=re4UrGxXmSEqg@mail.gmail.com>

On Fri, 1 Mar 2019 15:34:26 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> > +What:          /sys/bus/moxtet/devices/moxtet-<name>.<addr>/output_value
> > +Date:          March 2019
> > +KernelVersion: 5.2
> > +Contact:       Marek Behún <marek.behun@nic.cz>
> > +Description:   (RW) Read last written value or write value to the
> > module on
> > +               this Moxtet address. Format: %x  
> 
> What is the usecase for these?
> 
> If this is for debugging it should be in debugfs rather than in sysfs.
> 
> If it is here for random userspace drivers, we need some good
> explanation as to why they can't just be kernel drivers.

Hmm, it was for debugging purposes but the ability to write there is
not needed anymore... Shall I make it read/only? Or completely remove
it?

Marek

  reply	other threads:[~2019-03-01 15:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  3:58 [PATCH v3 bus+gpio 0/5] Add Moxtet bus and GPIO over Moxtet bus Marek Behún
2019-03-01  3:58 ` [PATCH v3 bus+gpio 1/5] bus: Add support for " Marek Behún
2019-03-05 11:24   ` Arnd Bergmann
2019-03-01  3:58 ` [PATCH v3 bus+gpio 2/5] dt-bindings: bus: Document moxtet bus binding Marek Behún
2019-03-01  3:58 ` [PATCH v3 bus+gpio 3/5] bus: moxtet: Add sysfs documentation Marek Behún
2019-03-01 14:34   ` Linus Walleij
2019-03-01 15:15     ` Marek Behun [this message]
2019-03-04 12:07       ` Linus Walleij
2019-03-05 11:11         ` Arnd Bergmann
2019-03-01  3:58 ` [PATCH v3 bus+gpio 4/5] drivers: gpio: Add support for GPIOs over Moxtet bus Marek Behún
2019-03-01  3:58 ` [PATCH v3 bus+gpio 5/5] dt-bindings: gpio: Document GPIOs via " Marek Behún
2019-03-01 14:36   ` Linus Walleij
2019-03-01 15:16     ` Marek Behun
2019-03-03 23:17     ` Marek Behun
2019-03-04  9:53       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301161510.20b15183@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).