From: Mark Brown <broonie@kernel.org>
To: Gareth Williams <gareth.williams.jx@renesas.com>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: dw: Add support for an optional interface clock
Date: Mon, 4 Mar 2019 00:04:33 +0000 [thread overview]
Message-ID: <20190304000433.GO23441@sirena.org.uk> (raw)
In-Reply-To: <1551360342-23981-3-git-send-email-gareth.williams.jx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On Thu, Feb 28, 2019 at 01:25:42PM +0000, Gareth Williams wrote:
> From: Phil Edworthy <phil.edworthy@renesas.com>
>
> The Synopsys SSI Controller has an interface clock, but most SoCs hide
> this away. However, on some SoCs you need to explicity enable the
> interface clock in order to access the registers. Therefore, add
> support for an optional interface clock.
This doesn't build for me:
CC drivers/spi/spi-dw-mmio.o
drivers/spi/spi-dw-mmio.c: In function ‘dw_spi_mmio_probe’:
drivers/spi/spi-dw-mmio.c:177:18: error: implicit declaration of function ‘devm_clk_get_optional’; did you mean ‘devm_gpiod_get_optional’? [-Werror=implicit-function-declaration]
dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
^~~~~~~~~~~~~~~~~~~~~
devm_gpiod_get_optional
drivers/spi/spi-dw-mmio.c:177:16: warning: assignment to ‘struct clk *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
^
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-04 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:25 [PATCH 0/2] spi: dw: Add support for an optional interface clock Gareth Williams
2019-02-28 13:25 ` [PATCH 1/2] dt: snps,dw-apb-ssi: Add clock bindings documentation Gareth Williams
2019-03-03 23:31 ` Mark Brown
2019-03-11 11:50 ` Gareth Williams
2019-02-28 13:25 ` [PATCH 2/2] spi: dw: Add support for an optional interface clock Gareth Williams
2019-03-04 0:04 ` Mark Brown [this message]
2019-03-04 14:46 ` Gareth Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304000433.GO23441@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).