From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk/console: Do not suppress information about dropped messages
Date: Mon, 4 Mar 2019 12:33:00 +0900 [thread overview]
Message-ID: <20190304033300.GA26291@jagdpanzerIV> (raw)
In-Reply-To: <20190227083043.j6nw7t6nqulim6t7@pathway.suse.cz>
On (02/27/19 09:30), Petr Mladek wrote:
> Good point! There is a simple fix for this. We could print the warning
> also when all messages are proceed and we are about to leave
> the for-cycle.
I'd prefer to have lost-messages reporting be less of a summary
and more of an "error". I think the sooner we report it the better.
I don't think that the time we need to print lost-messages on the
consoles is significant enough to worry about it; if call_console_drivers()
becomes such a problem that any extra char we print causes message-drop then
we can disable printk_time or/and printk caller_id prefix printout (can
save us more CPU cycles).
-ss
prev parent reply other threads:[~2019-03-04 3:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 12:49 [PATCH] printk/console: Do not suppress information about dropped messages Petr Mladek
2019-02-26 16:26 ` John Ogness
2019-02-27 2:55 ` Sergey Senozhatsky
2019-02-27 8:12 ` John Ogness
2019-02-27 8:44 ` Sergey Senozhatsky
2019-02-27 8:30 ` Petr Mladek
2019-02-27 8:54 ` John Ogness
2019-03-04 3:33 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304033300.GA26291@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).