From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80509C43381 for ; Mon, 4 Mar 2019 09:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECC8120836 for ; Mon, 4 Mar 2019 09:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbfCDJuW convert rfc822-to-8bit (ORCPT ); Mon, 4 Mar 2019 04:50:22 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:44707 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfCDJuW (ORCPT ); Mon, 4 Mar 2019 04:50:22 -0500 Received: from xps13 (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0F483200002; Mon, 4 Mar 2019 09:50:14 +0000 (UTC) Date: Mon, 4 Mar 2019 10:50:14 +0100 From: Miquel Raynal To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Harvey Hunt , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/9] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation Message-ID: <20190304105014.0cceea0a@xps13> In-Reply-To: <20190209192305.4434-2-paul@crapouillou.net> References: <20190209192305.4434-1-paul@crapouillou.net> <20190209192305.4434-2-paul@crapouillou.net> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, Paul Cercueil wrote on Sat, 9 Feb 2019 16:22:58 -0300: > The JZ4740 ECC hardware is not BCH but Reed-Solomon, so it makes more > sense to use the more generic ECC term. > > Signed-off-by: Paul Cercueil > --- > > Changes: > > v3: New patch > > v4: No change > > .../devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > index a5b940f18bf6..5a45cc54f46d 100644 > --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > @@ -1,4 +1,4 @@ > -* Ingenic JZ4780 NAND/BCH > +* Ingenic JZ4780 NAND/ECC > > This file documents the device tree bindings for NAND flash devices on the > JZ4780. NAND devices are connected to the NEMC controller (described in > @@ -14,10 +14,10 @@ Required NAND controller device properties: > an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC bank). > > Optional NAND controller device properties: > -- ingenic,bch-controller: To make use of the hardware BCH controller, this > - property must contain a phandle for the BCH controller node. The required > +- ingenic,bch-controller: To make use of the hardware ECC controller, this > + property must contain a phandle for the ECC controller node. The required I think there is already a 'ecc-engine' property used by MTK and Atmel NAND controllers to point to the ECC engine block. Please use this property instead of the ingenic specific one. > properties for this node are described below. If this is not specified, > - software BCH will be used instead. > + software ECC will be used instead. > > Optional children nodes: > - Individual NAND chips are children of the NAND controller node. > @@ -70,17 +70,17 @@ nemc: nemc@13410000 { > }; > }; > > -The BCH controller is a separate SoC component used for error correction on > +The ECC controller is a separate SoC component used for error correction on > NAND devices. The following is a description of the device properties for a > -BCH controller. > +ECC controller. > > -Required BCH properties: > +Required ECC properties: > - compatible: Should be one of: > * ingenic,jz4740-ecc > * ingenic,jz4725b-bch > * ingenic,jz4780-bch > -- reg: Should specify the BCH controller registers location and length. > -- clocks: Clock for the BCH controller. > +- reg: Should specify the ECC controller registers location and length. > +- clocks: Clock for the ECC controller. > > Example: > Thanks, Miquèl