From: Steven Rostedt <rostedt@goodmis.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
kgdb-bugreport@lists.sourceforge.net,
Brian Norris <briannorris@chromium.org>,
Vasyl Gomonovych <gomonovych@gmail.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
linux-kernel@vger.kernel.org, Baohong Liu <baohong.liu@intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 1/2] tracing: kdb: Fix ftdump to not sleep
Date: Tue, 5 Mar 2019 18:47:34 -0500 [thread overview]
Message-ID: <20190305184734.113a0fdc@gandalf.local.home> (raw)
In-Reply-To: <20190305233150.159633-1-dianders@chromium.org>
On Tue, 5 Mar 2019 15:31:49 -0800
Douglas Anderson <dianders@chromium.org> wrote:
> diff --git a/include/linux/ring_buffer.h b/include/linux/ring_buffer.h
> index 5b9ae62272bb..0c8ab8bf4cfb 100644
> --- a/include/linux/ring_buffer.h
> +++ b/include/linux/ring_buffer.h
> @@ -127,6 +127,8 @@ struct ring_buffer_event *
> ring_buffer_consume(struct ring_buffer *buffer, int cpu, u64 *ts,
> unsigned long *lost_events);
>
> +struct ring_buffer_iter *
> +_ring_buffer_read_prepare(struct ring_buffer *buffer, int cpu, gfp_t flags);
> struct ring_buffer_iter *
> ring_buffer_read_prepare(struct ring_buffer *buffer, int cpu);
> void ring_buffer_read_prepare_sync(void);
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 06e864a334bb..fd60007aa7a1 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -4201,6 +4201,29 @@ ring_buffer_consume(struct ring_buffer *buffer, int cpu, u64 *ts,
> }
> EXPORT_SYMBOL_GPL(ring_buffer_consume);
>
> +struct ring_buffer_iter *
> +_ring_buffer_read_prepare(struct ring_buffer *buffer, int cpu, gfp_t flags)
> +{
> + struct ring_buffer_per_cpu *cpu_buffer;
I don't care for this duplicate function. ring_buffer_read_prepare() is
only used in a few places, just add flags to it and to its users.
-- Steve
prev parent reply other threads:[~2019-03-05 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 23:31 [PATCH 1/2] tracing: kdb: Fix ftdump to not sleep Douglas Anderson
2019-03-05 23:31 ` [PATCH 2/2] tracing: kdb: Allow ftdump to skip all but the last few lines Douglas Anderson
2019-03-05 23:47 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305184734.113a0fdc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=baohong.liu@intel.com \
--cc=briannorris@chromium.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gomonovych@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).