From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA55C4360F for ; Thu, 7 Mar 2019 19:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E3DB20449 for ; Thu, 7 Mar 2019 19:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AKvYIYBH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbfCGTSm (ORCPT ); Thu, 7 Mar 2019 14:18:42 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38571 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfCGTSm (ORCPT ); Thu, 7 Mar 2019 14:18:42 -0500 Received: by mail-pg1-f193.google.com with SMTP id m2so12018364pgl.5 for ; Thu, 07 Mar 2019 11:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TV6edWcbYlz3eOY46NTUo2s3D92DBu7jHBspRKtTVuY=; b=AKvYIYBHonii6PjzihkI89A/58rguXKVbyCvwlgv38Thf44mGEdVYXDZ4pxI4RI90n 1SdZTFlhDv2JYfRhpGOqhhwbfHz8WqCaf3mtwy9vk+uv4W55pv8cXAwaz8afXx2mSilU 9qu3TuvF3P7K4yiUPOdIhs0+k3Rq7pymvbZOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TV6edWcbYlz3eOY46NTUo2s3D92DBu7jHBspRKtTVuY=; b=Q+fo7w99EyXzF9FGaSHNtFJhwUVX/3R3NXoEOLf0sR0xepbtmDwkmMr/fZkraqEhoL ZH71bFsQjrk6ssXTPMHV8RJuObfjpvc2brdNDxaPRYFSTQvYFWJa535OhXZlaWmLESiY zWjLU/aN9TYZypwP6cWTV0i0QepCO6y+NFke90iBRN2ODJGLBFGDqQcn6JEv0zucLU45 3AAoIHWMA2TGJLQPRJqeUUOK0e5t8tJSdLc3Xzzbogtmhoh/qw7ZE9kLPwZVQgxEAJjr vqoJGhEeekxk2hJMaB9tjkZejG03dPbqZfta+SnNKwpWju3wtV2ZN3zbb37+v66fzJKt GwwA== X-Gm-Message-State: APjAAAUPjKz8PaSGMDJJDI8X8vwOTv5fl6QK6j4DHFqDBF14pqDMdXpm Gh2qYkUFhFjpOcozEasW109P8A== X-Google-Smtp-Source: APXvYqzg7zeAqvorizTK3T0lBY3Ud5Hh4BZSMQv+Gij7w57AefHiOvXXC463y2F5t3/Pa3v+7DdK/g== X-Received: by 2002:aa7:8b17:: with SMTP id f23mr14499703pfd.171.1551986321882; Thu, 07 Mar 2019 11:18:41 -0800 (PST) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id n15sm15676625pfi.173.2019.03.07.11.18.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 11:18:41 -0800 (PST) Date: Thu, 7 Mar 2019 11:18:40 -0800 From: Matthias Kaehlcke To: Harish Bandi Cc: marcel@holtmann.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, anubhavg@codeaurora.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v1 0/2] Enable Bluetooth functionality for wcn3998. Message-ID: <20190307191840.GC138592@google.com> References: <1551961012-23898-1-git-send-email-c-hbandi@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1551961012-23898-1-git-send-email-c-hbandi@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + device tree folks On Thu, Mar 07, 2019 at 05:46:50PM +0530, Harish Bandi wrote: > This patch series we add support for wcn3998 BT chip set. This new chipset > is based from the wcn3990 with minimal power numbers. So here in this patch > The major difference between wcn3990 and wcn3998 is only power numbers. where > as init process and fw download is same with wcn3990.So we are leveraging the > existing code of wcn3990 along with readiing the voltages from the dts file. About how many different variants are we talking? Couldn't you just use a different compatible string for each variant and specify the voltage/current limits in the hci_qca.c driver, as currently done for the WCN3990? I understand that it requires touching the driver for each new variant, but it might be preferable to specify these static values in a single location, instead of repeating them in the DT snippets of every device that uses such a controller, with the possiblity of configuration errors. The DT folks can probably provide guidance on what is typically done in cases like this. Thanks Matthias