From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246B3C43381 for ; Fri, 8 Mar 2019 11:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA1D620854 for ; Fri, 8 Mar 2019 11:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbfCHLtv (ORCPT ); Fri, 8 Mar 2019 06:49:51 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57132 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfCHLtv (ORCPT ); Fri, 8 Mar 2019 06:49:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE0D480D; Fri, 8 Mar 2019 03:49:50 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C7903F706; Fri, 8 Mar 2019 03:49:48 -0800 (PST) Date: Fri, 8 Mar 2019 11:49:43 +0000 From: Lorenzo Pieralisi To: Ulf Hansson Cc: Mark Rutland , "Rafael J . Wysocki" , Sudeep Holla , Daniel Lezcano , Lina Iyer , Linux PM , Linux ARM , linux-arm-msm , Linux Kernel Mailing List Subject: Re: [PATCH 5/7] drivers: firmware: psci: Simplify state node parsing Message-ID: <20190308114943.GA27731@e107981-ln.cambridge.arm.com> References: <20190228135919.3747-1-ulf.hansson@linaro.org> <20190228135919.3747-6-ulf.hansson@linaro.org> <20190301172810.GR15517@lakrids.cambridge.arm.com> <20190306181519.GA3355@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 08, 2019 at 11:36:49AM +0100, Ulf Hansson wrote: [...] > Instead, my suggestion is according to what I propose in patch 4 and > $subject patch, which means minor adjustments to be able to pass the > struct cpuidle_driver * to the init functions. This, I need it for > next steps, but already at this point it improves things as it avoids > some of the OF parsing, and that's good, isn't it? I will take the patches Mark ACKed and send them for v5.2 as early as it gets in v5.1-rc* cycle. For this one maybe you can post the changes on top and see what's the best way forward ? I agree that duplicating idle state parsing code across back-ends is silly - we just want to keep PSCI and kernel data structure decoupled. Post the code on top and we will find a way forward, OK ? Thanks, Lorenzo