From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A64C43381 for ; Fri, 8 Mar 2019 13:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 146BF20661 for ; Fri, 8 Mar 2019 13:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552050075; bh=F50Opl0m8B1UjAdxZxX6o/ZNw+1kvvP4s7nh74I4fRQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eM/6Ei1vkVYI+QIoOzakEoII/gcPB/chn/1d4v9d+ABFxicoHoO6CPmFoMbxHd4pH MVbt3YW2Uxq1rUVFG0WMK2uBo9CSE5FyP+dzHlDYb3Lo5nbSHLUYZadXSOrZZfu/ma 3CfL3RmQd7fFlWK/NCPE7jKNGU1fRpuibwcQMOIc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728401AbfCHNBN (ORCPT ); Fri, 8 Mar 2019 08:01:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:38348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728384AbfCHNBI (ORCPT ); Fri, 8 Mar 2019 08:01:08 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BB9B20449; Fri, 8 Mar 2019 13:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552050068; bh=F50Opl0m8B1UjAdxZxX6o/ZNw+1kvvP4s7nh74I4fRQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AA3XV4OnRrwLNC29H2gVAZg6WH+UQ0XZQXsocZvFcPYcMiFmO8i6tZIXdkGebk814 SfiNhMa8g2ofBFj+1xdg0PXZbOxgMEUPNi1S5mofvCp7KEFxrxt1b/K8elJvklCjaH A6n0OCGntvhhBsdC4+vsvtSnjgeCFyjBYqkrsQ3E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Ahern , "David S. Miller" Subject: [PATCH 4.19 44/68] ipv4: Return error for RTA_VIA attribute Date: Fri, 8 Mar 2019 13:50:14 +0100 Message-Id: <20190308124912.860675285@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190308124910.696595153@linuxfoundation.org> References: <20190308124910.696595153@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Ahern [ Upstream commit b6e9e5df4ecf100f6a10ab2ade8e46d47a4b9779 ] IPv4 currently does not support nexthops outside of the AF_INET family. Specifically, it does not handle RTA_VIA attribute. If it is passed in a route add request, the actual route added only uses the device which is clearly not what the user intended: $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0 $ ip ro ls ... 172.16.1.0/24 dev eth0 Catch this and fail the route add: $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0 Error: IPv4 does not support RTA_VIA attribute. Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes") Signed-off-by: David Ahern Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/fib_frontend.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -700,6 +700,10 @@ static int rtm_to_fib_config(struct net case RTA_GATEWAY: cfg->fc_gw = nla_get_be32(attr); break; + case RTA_VIA: + NL_SET_ERR_MSG(extack, "IPv4 does not support RTA_VIA attribute"); + err = -EINVAL; + goto errout; case RTA_PRIORITY: cfg->fc_priority = nla_get_u32(attr); break;