From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, tony@atomide.com,
lee.jones@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
Date: Fri, 8 Mar 2019 16:14:22 +0100 [thread overview]
Message-ID: <20190308151422.GA10378@amd> (raw)
In-Reply-To: <20190307220947.20057-2-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
Hi!
> Update the properties for the lm3532 device node for droid4.
> With this change the backlight LED string and the keypad
> LED strings will be controlled separately.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> arch/arm/boot/dts/omap4-droid4-xt894.dts | 27 +++++++++++++++++-------
> 1 file changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> index e21ec929f096..94e3d53dbcf3 100644
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -6,6 +6,7 @@
> /dts-v1/;
>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/leds-lm3532.h>
> #include "omap443x.dtsi"
> #include "motorola-cpcap-mapphone.dtsi"
>
> @@ -383,20 +384,30 @@
> };
>
> &i2c1 {
> - lm3532@38 {
> + led-controller@38 {
> compatible = "ti,lm3532";
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0x38>;
>
> enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>
> - lcd_backlight: backlight {
> - compatible = "ti,lm3532-backlight";
> + ramp-up-ms = <LM3532_RAMP_1024us>;
> + ramp-down-ms = <LM3532_RAMP_65536us>;
I guess dt people will have some comments here. I'd expect
ramp-up-us = <1024> would be more natural.
> + lcd_backlight: led@0 {
> + reg = <0>;
> + led-sources = <2>;
> + ti,led-mode = <LM3532_BL_MODE_MANUAL>;
> + label = "backlight";
Ok, so we'll have lm3532::backlight. That is not too useful, as it
does not tell userland what kaclight it is.
main_display::backlight ?
OTOH this one is not too important as backlight subsystem should
handle this.
> + led@1 {
> + reg = <1>;
> + led-sources = <1>;
> + ti,led-mode = <LM3532_BL_MODE_MANUAL>;
> + label = "keypad";
I guess best variant would be inputX::backlight here, but that might
be tricky to implement.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-08 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:09 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-07 22:09 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-08 15:14 ` Pavel Machek [this message]
2019-03-08 15:45 ` Dan Murphy
2019-03-08 21:06 ` Pavel Machek
2019-03-08 21:08 ` Dan Murphy
2019-03-07 22:09 ` [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-07 22:09 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-08 13:28 ` Dan Murphy
2019-03-10 19:49 ` Jacek Anaszewski
2019-03-11 11:36 ` Dan Murphy
2019-03-11 17:22 ` Jacek Anaszewski
2019-03-11 17:24 ` Dan Murphy
2019-03-11 17:30 ` Joe Perches
2019-03-11 17:47 ` Dan Murphy
2019-03-13 15:49 ` Joe Perches
2019-03-21 14:28 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-21 14:28 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-04-04 0:03 ` Tony Lindgren
2019-04-04 20:12 ` Jacek Anaszewski
2019-04-04 22:00 ` Tony Lindgren
2019-04-07 18:31 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308151422.GA10378@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).