From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A6EC43381 for ; Fri, 8 Mar 2019 15:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E1D120868 for ; Fri, 8 Mar 2019 15:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbfCHP6Q (ORCPT ); Fri, 8 Mar 2019 10:58:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:59442 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726171AbfCHP6Q (ORCPT ); Fri, 8 Mar 2019 10:58:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A7998AFAF; Fri, 8 Mar 2019 15:58:14 +0000 (UTC) Date: Fri, 8 Mar 2019 16:58:14 +0100 From: Petr Mladek To: Greg Kroah-Hartman Cc: Calvin Owens , John Ogness , Sergey Senozhatsky , Steven Rostedt , Greg Kroah-Hartman , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus Message-ID: <20190308155814.rzsjrzgwfcm4p5sk@pathway.suse.cz> References: <087b13f7812b32cc7c3f9efea71c9bcf324dd031.1551486732.git.calvinowens@fb.com> <87ef7ioyzw.fsf@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ef7ioyzw.fsf@linutronix.de> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2019-03-08 03:56:19, John Ogness wrote: > On 2019-03-02, Calvin Owens wrote: > > This patch embeds a device struct in the console struct, and registers > > them on a "console" bus so we can expose attributes in sysfs. > > I expect that "class" would be more appropriate than "bus". These > devices really are grouped together based on their function and not the > medium by which they are accessed. Good point. "class" looks better to me as well. Greg, any opinion, where to put the entries for struct console ? Best Regards, Petr