From: "Tobin C. Harding" <me@tobin.cc>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Christopher Lameter <cl@linux.com>,
"Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 02/15] slub: Add isolate() and migrate() methods
Date: Sat, 9 Mar 2019 06:53:22 +1100 [thread overview]
Message-ID: <20190308195322.GA25102@eros.localdomain> (raw)
In-Reply-To: <20190308162237.GD373@cisco>
On Fri, Mar 08, 2019 at 09:22:37AM -0700, Tycho Andersen wrote:
> On Fri, Mar 08, 2019 at 04:15:46PM +0000, Christopher Lameter wrote:
> > On Fri, 8 Mar 2019, Tycho Andersen wrote:
> >
> > > On Fri, Mar 08, 2019 at 03:14:13PM +1100, Tobin C. Harding wrote:
> > > > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > > > index f9d89c1b5977..754acdb292e4 100644
> > > > --- a/mm/slab_common.c
> > > > +++ b/mm/slab_common.c
> > > > @@ -298,6 +298,10 @@ int slab_unmergeable(struct kmem_cache *s)
> > > > if (!is_root_cache(s))
> > > > return 1;
> > > >
> > > > + /*
> > > > + * s->isolate and s->migrate imply s->ctor so no need to
> > > > + * check them explicitly.
> > > > + */
> > >
> > > Shouldn't this implication go the other way, i.e.
> > > s->ctor => s->isolate & s->migrate
> >
> > A cache can have a constructor but the object may not be movable (I.e.
> > currently dentries and inodes).
>
> Yep, thanks. Somehow I got confused by the comment.
I removed code here from the original RFC-v2, if this comment is
confusing perhaps we are better off without it.
thanks,
Tobin.
next prev parent reply other threads:[~2019-03-08 19:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 4:14 [RFC 00/15] mm: Implement Slab Movable Objects (SMO) Tobin C. Harding
2019-03-08 4:14 ` [RFC 01/15] slub: Create sysfs field /sys/slab/<cache>/ops Tobin C. Harding
2019-03-11 21:23 ` Roman Gushchin
2019-03-12 1:16 ` Tobin C. Harding
2019-03-08 4:14 ` [RFC 02/15] slub: Add isolate() and migrate() methods Tobin C. Harding
2019-03-08 15:28 ` Tycho Andersen
2019-03-08 16:15 ` Christopher Lameter
2019-03-08 16:22 ` Tycho Andersen
2019-03-08 19:53 ` Tobin C. Harding [this message]
2019-03-08 20:08 ` Tycho Andersen
2019-03-11 21:51 ` Roman Gushchin
2019-03-12 1:08 ` Tobin C. Harding
2019-03-12 4:35 ` Christopher Lameter
2019-03-12 18:47 ` Roman Gushchin
2019-03-08 4:14 ` [RFC 03/15] tools/vm/slabinfo: Add support for -C and -F options Tobin C. Harding
2019-03-11 21:54 ` Roman Gushchin
2019-03-12 1:20 ` Tobin C. Harding
2019-03-08 4:14 ` [RFC 04/15] slub: Enable Slab Movable Objects (SMO) Tobin C. Harding
2019-03-11 22:48 ` Roman Gushchin
2019-03-12 1:47 ` Tobin C. Harding
2019-03-12 18:00 ` Roman Gushchin
2019-03-12 4:39 ` Christopher Lameter
2019-03-08 4:14 ` [RFC 05/15] slub: Sort slab cache list Tobin C. Harding
2019-03-08 4:14 ` [RFC 06/15] tools/vm/slabinfo: Add remote node defrag ratio output Tobin C. Harding
2019-03-08 4:14 ` [RFC 07/15] slub: Add defrag_used_ratio field and sysfs support Tobin C. Harding
2019-03-08 16:01 ` Tycho Andersen
2019-03-11 6:04 ` Tobin C. Harding
2019-03-08 4:14 ` [RFC 08/15] tools/vm/slabinfo: Add defrag_used_ratio output Tobin C. Harding
2019-03-08 4:14 ` [RFC 09/15] slub: Enable slab defragmentation using SMO Tobin C. Harding
2019-03-11 23:35 ` Roman Gushchin
2019-03-12 1:49 ` Tobin C. Harding
2019-03-08 4:14 ` [RFC 10/15] tools/testing/slab: Add object migration test module Tobin C. Harding
2019-03-08 4:14 ` [RFC 11/15] tools/testing/slab: Add object migration test suite Tobin C. Harding
2019-03-08 4:14 ` [RFC 12/15] xarray: Implement migration function for objects Tobin C. Harding
2019-03-12 0:16 ` Roman Gushchin
2019-03-12 1:54 ` Tobin C. Harding
2019-03-08 4:14 ` [RFC 13/15] tools/testing/slab: Add XArray movable objects tests Tobin C. Harding
2019-03-08 4:14 ` [RFC 14/15] slub: Enable move _all_ objects to node Tobin C. Harding
2019-03-08 4:14 ` [RFC 15/15] slub: Enable balancing slab objects across nodes Tobin C. Harding
2019-03-12 0:09 ` [RFC 00/15] mm: Implement Slab Movable Objects (SMO) Roman Gushchin
2019-03-12 1:48 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308195322.GA25102@eros.localdomain \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=tobin@kernel.org \
--cc=tycho@tycho.ws \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).