From: Mao Wenan <maowenan@huawei.com>
To: <Larry.Finger@lwfinger.net>, <gregkh@linuxfoundation.org>,
<straube.linux@gmail.com>, <jananis37@gmail.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <davem@davemloft.net>
Subject: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()
Date: Sat, 9 Mar 2019 11:26:00 +0800 [thread overview]
Message-ID: <20190309032600.98732-1-maowenan@huawei.com> (raw)
Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
index 714f7a70ed64..beae367df93b 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
@@ -180,9 +180,8 @@ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *addr)
{
struct list_head *phead, *plist;
struct wlan_network *pnetwork = NULL;
- u8 zero_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
- if (!memcmp(zero_addr, addr, ETH_ALEN)) {
+ if (is_zero_ether_addr(addr)) {
pnetwork = NULL;
goto exit;
}
--
2.20.1
next reply other threads:[~2019-03-09 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 3:26 Mao Wenan [this message]
2019-03-12 6:29 ` [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp() maowenan
2019-03-12 6:35 ` Joe Perches
2019-03-12 6:58 ` maowenan
2019-03-12 7:06 ` Joe Perches
2019-03-12 7:14 ` Julia Lawall
2019-03-12 12:02 ` Greg KH
2019-03-17 11:26 ` Greg KH
2019-03-18 13:57 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309032600.98732-1-maowenan@huawei.com \
--to=maowenan@huawei.com \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jananis37@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).