From: Greg KH <gregkh@linuxfoundation.org>
To: Kimberly Brown <kimbrownkd@gmail.com>
Cc: Michael Kelley <mikelley@microsoft.com>,
Long Li <longli@microsoft.com>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used
Date: Sat, 9 Mar 2019 08:21:35 +0100 [thread overview]
Message-ID: <20190309072135.GG3882@kroah.com> (raw)
In-Reply-To: <20190308224611.GA3047@ubu-Virtual-Machine>
On Fri, Mar 08, 2019 at 05:46:11PM -0500, Kimberly Brown wrote:
> static struct kobj_type vmbus_chan_ktype = {
> .sysfs_ops = &vmbus_chan_sysfs_ops,
> .release = vmbus_chan_release,
> - .default_attrs = vmbus_chan_attrs,
As discussed on IRC, a kobj_type needs to get an attribute group one of
these days, not just a attribute list :)
So thanks for persisting with this, sorry for the earlier review
comments, you were totally right about this, nice work.
Minor review comments below:
> };
>
> /*
> @@ -1571,11 +1624,34 @@ int vmbus_add_channel_kobj(struct hv_device *dev, struct vmbus_channel *channel)
> if (ret)
> return ret;
>
> + ret = sysfs_create_group(kobj, &vmbus_chan_group);
> + channel->sysfs_group_ready = !ret;
Why do you need this flag?
> +
> + if (ret) {
> + /*
> + * If an error is returned to the calling functions, those
> + * functions will call kobject_put() on the channel kobject,
> + * which will cleanup the empty channel directory created by
> + * kobject_init_and_add().
Why is this comment needed?
> + */
> + pr_err("Unable to set up channel sysfs files\n");
dev_err() to show who had the problem with the files?
> + return ret;
> + }
> +
> kobject_uevent(kobj, KOBJ_ADD);
>
> return 0;
> }
>
> +/*
> + * vmbus_remove_channel_attr_group - remove the channel's attribute group
> + */
> +void vmbus_remove_channel_attr_group(struct vmbus_channel *channel)
> +{
> + if (channel->sysfs_group_ready)
> + sysfs_remove_group(&channel->kobj, &vmbus_chan_group);
You should be able to just always remove these, no need for a flag to
say you have created them or not, right?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-09 7:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 9:57 [PATCH 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data Kimberly Brown
2019-02-08 9:58 ` [PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0 Kimberly Brown
2019-02-08 22:28 ` Stephen Hemminger
2019-02-08 10:01 ` [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set Kimberly Brown
2019-02-08 22:32 ` Stephen Hemminger
2019-02-11 7:01 ` Kimberly Brown
2019-02-11 18:02 ` Stephen Hemminger
2019-02-14 6:11 ` Kimberly Brown
2019-02-14 19:50 ` Stephen Hemminger
2019-02-19 5:37 ` [PATCH v2 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data Kimberly Brown
2019-02-19 5:38 ` [PATCH v2 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0 Kimberly Brown
2019-02-20 14:35 ` Michael Kelley
[not found] ` <cover.1550554279.git.kimbrownkd@gmail.com>
2019-02-19 5:38 ` [PATCH v2 2/2] Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set Kimberly Brown
2019-02-20 16:11 ` Michael Kelley
2019-02-26 5:35 ` [PATCH v3] Drivers: hv: vmbus: Expose monitor data when channel uses monitor pages Kimberly Brown
2019-02-26 8:18 ` Greg KH
2019-03-01 19:18 ` [PATCH v4] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used Kimberly Brown
2019-03-02 18:39 ` Michael Kelley
2019-03-03 21:40 ` Kimberly Brown
2019-03-03 8:05 ` Greg KH
2019-03-03 21:11 ` Kimberly Brown
2019-03-04 7:38 ` Greg KH
2019-03-08 22:46 ` [PATCH v5] " Kimberly Brown
2019-03-09 7:21 ` Greg KH [this message]
2019-03-12 0:04 ` Kimberly Brown
2019-03-19 4:04 ` [PATCH v6] " Kimberly Brown
2019-03-19 9:26 ` Greg KH
2019-03-20 20:18 ` Michael Kelley
2019-03-21 3:57 ` Sasha Levin
2019-03-21 15:55 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309072135.GG3882@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alexander.Levin@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kimbrownkd@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).