From: Wolfram Sang <wsa@the-dreams.de>
To: Shikai Wang <sxauwsk@163.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: cadence: try reset when master receive arbitration lost
Date: Sat, 9 Mar 2019 10:49:04 +0100 [thread overview]
Message-ID: <20190309094904.GC1340@kunai> (raw)
In-Reply-To: <20190309094452.GB1340@kunai>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Sat, Mar 09, 2019 at 10:44:52AM +0100, Wolfram Sang wrote:
> On Sat, Feb 23, 2019 at 10:48:43AM +0100, Wolfram Sang wrote:
> > On Tue, Feb 19, 2019 at 09:24:47AM +0800, Shikai Wang wrote:
> > > When the adapter receive arbitration lost error interrupts,
> > > cdns_i2c_master_xfer return to the caller directly instead of resetting
> > > the adapter which resulted in the adapter being out of control.
> > >
> > > So when driver detect err_status such as arbitration lost,
> > > then try to repair and fix it.
> >
> > Just checking because resetting looks like a big hammer to me: there is
> > no way to gracefully recover form 'arbitration lost' interrupt?
>
> I am still wondering about this but since it is acked by the maintainer:
>
> Applied to for-current, thanks!
Oops, I was mixing this up with
[PATCHv4] i2c: cadence: Fix the driver in interrupt flurry case
This one doesn't have an ack from Michal. Dropping it again.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-09 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 1:24 [PATCH v2] i2c: cadence: try reset when master receive arbitration lost Shikai Wang
2019-02-23 9:48 ` Wolfram Sang
2019-03-09 9:44 ` Wolfram Sang
2019-03-09 9:49 ` Wolfram Sang [this message]
2019-11-05 7:42 ` Shubhrajyoti Datta
2019-11-05 8:47 ` sxauwsk
2019-11-07 6:13 ` Shubhrajyoti Datta
2019-11-08 12:25 ` sxauwsk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309094904.GC1340@kunai \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=sxauwsk@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).