From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB69C10F00 for ; Sat, 9 Mar 2019 18:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2280A20815 for ; Sat, 9 Mar 2019 18:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552155897; bh=ptjD8mkNhqOFbBTyepNsMwh3Bqxakssmd0up4SjmIRE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YpxdtDQlUpHB+d/n55lyCc5BByzo486otgfoBh2IvmHqhA9Zu57ZtbfKiBrMarY2b Y6iQCR+o5+ZWyttyk/PTKvFt1m49+9snY35JZvTdb/gygKGvoYYoowkWpWb4yNPzsy mBP825o5e61suwTkBYbZpu4THInX8wM15hTU4990= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbfCISYz (ORCPT ); Sat, 9 Mar 2019 13:24:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:48086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbfCISYz (ORCPT ); Sat, 9 Mar 2019 13:24:55 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5C92206DF; Sat, 9 Mar 2019 18:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552155894; bh=ptjD8mkNhqOFbBTyepNsMwh3Bqxakssmd0up4SjmIRE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dfIoNtJLFi6HxuypMAdaGGLxFQ2/AS6MwB9L0InR2XHt+2cLB+4xiP7A5R0aZXQuN LC+TS6VGLtHvpB08k7pg1jPLwSr39OR7ByiWXn4CxmNsNNfLSokGxiCnBlCKLRNcAf OKI/6WZ2LLaKAeUPFfGIm0geLAskDDKs1OOp+L9Y= Date: Sat, 9 Mar 2019 18:24:49 +0000 From: Jonathan Cameron To: Sven Van Asbroeck Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Linux Kernel Mailing List , Matt Ranostay Subject: Re: [PATCH] iio: proximity: as3935: fix use-after-free on device remove Message-ID: <20190309182449.45cd1b28@archlinux> In-Reply-To: References: <20190306174559.17362-1-TheSven73@gmail.com> <20190308171244.00001ec8@huawei.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Mar 2019 12:49:30 -0500 Sven Van Asbroeck wrote: > On Fri, Mar 8, 2019 at 12:13 PM Jonathan Cameron > wrote: > > > > Your description makes it clear that there are multiple things in the patch. > > Don't do a 'while we were here' in a patch doing something else please. > > Separate patches. > > > > The proposed solution (adding devm_) fixes multiple issues, so that can stay > as a single patch, right? > > It's the 'while we're here' you'd like to see removed? Can do. That's the one. Just the & removal. The rest makes sense in one patch as you say. Jonathan