From: David Miller <davem@davemloft.net>
To: kjlu@umn.edu
Cc: pakki001@umn.edu, isdn@linux-pingi.de, baijiaju1990@gmail.com,
gustavo@embeddedor.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference
Date: Sun, 10 Mar 2019 10:56:50 -0700 (PDT) [thread overview]
Message-ID: <20190310.105650.162175260208324347.davem@davemloft.net> (raw)
In-Reply-To: <20190309054605.23912-1-kjlu@umn.edu>
From: Kangjie Lu <kjlu@umn.edu>
Date: Fri, 8 Mar 2019 23:46:04 -0600
> In case ioremap fails, the fix reports an error and returns.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
First, you shouldn't print the information log message if this fails.
Second you are leaking hc->hw.fifos, you have to clean up any resources
allocated up until this point if you fail.
prev parent reply other threads:[~2019-03-10 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 5:46 [PATCH] isdn: hfcpci: fix potential NULL pointer dereference Kangjie Lu
2019-03-10 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190310.105650.162175260208324347.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baijiaju1990@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=isdn@linux-pingi.de \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).