From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E0BC43381 for ; Sun, 10 Mar 2019 18:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FF55206DF for ; Sun, 10 Mar 2019 18:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbfCJSNm (ORCPT ); Sun, 10 Mar 2019 14:13:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:58138 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726660AbfCJSNm (ORCPT ); Sun, 10 Mar 2019 14:13:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B535A1477F2AD; Sun, 10 Mar 2019 11:13:41 -0700 (PDT) Date: Sun, 10 Mar 2019 11:13:41 -0700 (PDT) Message-Id: <20190310.111341.101594049285839134.davem@davemloft.net> To: gustavo@embeddedor.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ide: hpt366: mark expected switch fall-throughs From: David Miller In-Reply-To: <20190110163423.GA17072@embeddedor> References: <20190110163423.GA17072@embeddedor> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 10 Mar 2019 11:13:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 10 Jan 2019 10:34:23 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that, in this particular case, I removed the "else: " > part from the comment. As we are now using Warning level 3: > -Wimplicit-fallthrough=3, this is what GCC is expecting to > find. > > Signed-off-by: Gustavo A. R. Silva Applied.