Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

From: Jonathan Cameron <jic23@kernel.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Tomasz Duszynski <tduszyns@gmail.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove
Date: Sun, 10 Mar 2019 09:34:32 +0000	[thread overview]
Message-ID: <20190310093432.7751f45d@archlinux> (raw)
In-Reply-To: <CAGngYiW9h1d1uHKTKE08OR+V-gBB0qxKE=kmo9NriC=FJddUGA@mail.gmail.com>

On Sat, 9 Mar 2019 08:03:44 -0500
Sven Van Asbroeck <thesven73@gmail.com> wrote:

> On Sat, Mar 9, 2019 at 5:24 AM Tomasz Duszynski <tduszyns@gmail.com> wrote:
> >
> > What I meant is that delayed work initialization could stay where it was.
> > The reason you moved it is readability improvement so to me it is more
> > of a cleanup hence I suggested a separate patch. Up to you.  
> 
> Ah, I see what you mean now.
> 
> I'm ok with splitting this up, but we should probably ask the maintainer
> (Jonathan) what he prefers, because he's the one who will have to take
> two small patches instead of one. And the second patch is a one-liner.

I don't mind either way (definitely a marginal case!) but as we have
this one and the alignment tidy up is trivial...

Applied with the alignment tweaked to the togreg branch of iio.git
and pushed out as testing.

I'm not taking this the fast way or proposing it for stable as
whilst the race is there, I don't think anyone has actually managed
to trigger it.

Thanks,

Jonathan