From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 11/15] perf tools report: Implement browsing of individual samples
Date: Mon, 11 Mar 2019 13:32:27 +0100 [thread overview]
Message-ID: <20190311123227.GA26829@krava> (raw)
In-Reply-To: <20190309055628.21617-12-andi@firstfloor.org>
On Fri, Mar 08, 2019 at 09:56:24PM -0800, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 08e2b3be4c1b..da3a944f42aa 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -445,6 +445,14 @@ static int hist_entry__init(struct hist_entry *he,
> return -ENOMEM;
> }
> }
> +
> + if (symbol_conf.res_sample) {
> + he->res_samples = calloc(sizeof(struct res_sample),
> + symbol_conf.res_sample);
> + if (!he->res_samples)
you need to free the memory in here, anyway this function
just changed, so please rebase on latest Arnaldo's perf/core
jirka
> + return -ENOMEM;
> + }
> +
SNIP
next prev parent reply other threads:[~2019-03-11 12:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 5:56 Support sample context in perf report Andi Kleen
2019-03-09 5:56 ` [PATCH v5 01/15] perf tools: Add utility function to fetch executable Andi Kleen
2019-03-11 12:32 ` Jiri Olsa
2019-03-09 5:56 ` [PATCH v5 02/15] perf tools script: Support insn output for normal samples Andi Kleen
2019-03-09 5:56 ` [PATCH v5 03/15] perf tools script: Filter COMM/FORK/.. events by CPU Andi Kleen
2019-03-11 12:32 ` Jiri Olsa
2019-03-09 5:56 ` [PATCH v5 04/15] perf tools report: Support nano seconds Andi Kleen
2019-03-09 5:56 ` [PATCH v5 05/15] perf tools report: Parse time quantum Andi Kleen
2019-03-09 5:56 ` [PATCH v5 06/15] perf tools report: Support time sort key Andi Kleen
2019-03-09 5:56 ` [PATCH v5 07/15] perf tools report: Use less for scripts output Andi Kleen
2019-03-22 22:07 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2019-03-09 5:56 ` [PATCH v5 08/15] perf tools report: Support running scripts for current time range Andi Kleen
2019-03-09 5:56 ` [PATCH v5 09/15] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-03-09 5:56 ` [PATCH v5 10/15] perf tools: Add utility function to print ns time stamps Andi Kleen
2019-03-09 5:56 ` [PATCH v5 11/15] perf tools report: Implement browsing of individual samples Andi Kleen
2019-03-11 12:32 ` Jiri Olsa [this message]
2019-03-09 5:56 ` [PATCH v5 12/15] perf tools: Add some new tips describing the new options Andi Kleen
2019-03-09 5:56 ` [PATCH v5 13/15] perf tools report: Add custom scripts to script menu Andi Kleen
2019-03-09 5:56 ` [PATCH v5 14/15] perf tools script: Add array bound checking to list_scripts Andi Kleen
2019-03-09 5:56 ` [PATCH v5 15/15] perf tools ui: Fix ui popup browser for many entries Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311123227.GA26829@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).