From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: David Airlie <airlied@linux.ie>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vkms: Remove useless call to drm_connector_register()
Date: Mon, 11 Mar 2019 15:00:04 -0300 [thread overview]
Message-ID: <20190311180004.6wljdhyhkmn66lpi@smtp.gmail.com> (raw)
In-Reply-To: <20190311132938.GG2665@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]
On 03/11, Daniel Vetter wrote:
> On Sun, Mar 10, 2019 at 06:22:41PM -0300, Rodrigo Siqueira wrote:
> > The function vkms_output_init() is invoked during the module
> > initialization, and it handles the creation/configuration of the vkms
> > essential elements (e.g., connectors, encoder, etc). Among the
> > initializations, this function tries to initialize a connector and
> > register it by calling drm_connector_register(). However, inside the
> > drm_connector_register(), at the beginning of this function there is the
> > following validation:
> >
> > if (!connector->dev->registered)
> > return 0;
> >
> > In this sense, invoke drm_connector_register() after initializing the
> > connector has no effect because the register field is false. The
> > connector register happens when drm_dev_register() is invoked.
> > Therefore, this commit removes the drm_connector_register() from
> > vkms_output_init().
> >
> > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> > ---
> > drivers/gpu/drm/vkms/vkms_output.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c
> > index 3b162b25312e..a6cee4c279c2 100644
> > --- a/drivers/gpu/drm/vkms/vkms_output.c
> > +++ b/drivers/gpu/drm/vkms/vkms_output.c
> > @@ -71,12 +71,6 @@ int vkms_output_init(struct vkms_device *vkmsdev)
> >
> > drm_connector_helper_add(connector, &vkms_conn_helper_funcs);
> >
> > - ret = drm_connector_register(connector);
>
> Yeah that's only needed for connectors added when hotplugging at runtime,
> not for connectors which are created at driver load time.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> btw same issue exists with the drm_connector_unregister, that's also not
> needed.
Thanks for your review :)
Should I send a V2 that also removes the drm_connector_unregister()? Or
should I send it in a separated patch?
Best Regards
> -Daniel
>
> > - if (ret) {
> > - DRM_ERROR("Failed to register connector\n");
> > - goto err_connector_register;
> > - }
> > -
> > ret = drm_encoder_init(dev, encoder, &vkms_encoder_funcs,
> > DRM_MODE_ENCODER_VIRTUAL, NULL);
> > if (ret) {
> > --
> > 2.21.0
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-11 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 21:22 [PATCH] drm/vkms: Remove useless call to drm_connector_register() Rodrigo Siqueira
2019-03-11 13:29 ` Daniel Vetter
2019-03-11 18:00 ` Rodrigo Siqueira [this message]
2019-03-11 18:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311180004.6wljdhyhkmn66lpi@smtp.gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).