From: "Jesús Castro" <x51v4n@gmail.com>
To: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, sashal@kernel.org
Cc: miguel.bernal@zapopan.tecmm.edu.mx, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, joe@perches.org,
"Jesús Castro" <x51v4n@gmail.com>,
"Joe Perches" <joe@perches.com>
Subject: [PATCH v2] hv: utils: enhance code for human read
Date: Mon, 11 Mar 2019 18:29:49 -0600 [thread overview]
Message-ID: <20190312002949.4937-1-x51v4n@gmail.com> (raw)
In-Reply-To: <20190305234542.5243-1-x51v4n@gmail.com>
The if/else block from hvt_op_open function can be written
as a switch/case block, and the bool issue_reset variable
is avoided.
No functional change made.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Jesús Castro <x51v4n@gmail.com>
---
v2: Refactoring hvt_op_open function with a switch/case block.
Change subject from: fix coding style
drivers/hv/hv_utils_transport.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index 832777527936..6b27dd7be9bb 100644
--- a/drivers/hv/hv_utils_transport.c
+++ b/drivers/hv/hv_utils_transport.c
@@ -125,35 +125,35 @@ static int hvt_op_open(struct inode *inode, struct file *file)
{
struct hvutil_transport *hvt;
int ret = 0;
- bool issue_reset = false;
hvt = container_of(file->f_op, struct hvutil_transport, fops);
mutex_lock(&hvt->lock);
- if (hvt->mode == HVUTIL_TRANSPORT_DESTROY) {
- ret = -EBADF;
- } else if (hvt->mode == HVUTIL_TRANSPORT_INIT) {
+ switch (hvt->mode) {
+ case HVUTIL_TRANSPORT_INIT:
/*
* Switching to CHARDEV mode. We switch bach to INIT when
* device gets released.
*/
hvt->mode = HVUTIL_TRANSPORT_CHARDEV;
- }
- else if (hvt->mode == HVUTIL_TRANSPORT_NETLINK) {
+ break;
+ case HVUTIL_TRANSPORT_NETLINK:
/*
* We're switching from netlink communication to using char
* device. Issue the reset first.
*/
- issue_reset = true;
hvt->mode = HVUTIL_TRANSPORT_CHARDEV;
- } else {
+ hvt_reset(hvt);
+ break;
+ case HVUTIL_TRANSPORT_DESTROY:
+ ret = -EBADF;
+ break;
+ default:
ret = -EBUSY;
+ break;
}
- if (issue_reset)
- hvt_reset(hvt);
-
mutex_unlock(&hvt->lock);
return ret;
--
2.21.0
next prev parent reply other threads:[~2019-03-12 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 23:45 [PATCH] hv: utils: fix coding style Jesús Castro
2019-03-06 0:37 ` Joe Perches
2019-03-11 23:21 ` Jesús Castro
2019-03-12 0:29 ` Jesús Castro [this message]
2019-03-25 22:42 ` [PATCH v2] hv: utils: enhance code for human read Jesús Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312002949.4937-1-x51v4n@gmail.com \
--to=x51v4n@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=joe@perches.com \
--cc=joe@perches.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.bernal@zapopan.tecmm.edu.mx \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).