From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56564C10F00 for ; Tue, 12 Mar 2019 03:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BCF5214AF for ; Tue, 12 Mar 2019 03:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfCLDwq (ORCPT ); Mon, 11 Mar 2019 23:52:46 -0400 Received: from mga04.intel.com ([192.55.52.120]:58135 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbfCLDwa (ORCPT ); Mon, 11 Mar 2019 23:52:30 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2019 20:52:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,469,1544515200"; d="scan'208";a="154157114" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga001.fm.intel.com with ESMTP; 11 Mar 2019 20:52:29 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 4377A301E2E; Mon, 11 Mar 2019 20:52:29 -0700 (PDT) From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 1/3] perf, tools, report: Handle samples without time Date: Mon, 11 Mar 2019 20:52:22 -0700 Message-Id: <20190312035224.30350-2-andi@firstfloor.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190312035224.30350-1-andi@firstfloor.org> References: <20190312035224.30350-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen When a sample doesn't have a time stamp (e.g. from --no-time), show the beginning of the trace for res samples instead of generating an impossible time range that errors out. Signed-off-by: Andi Kleen --- tools/perf/ui/browsers/res_sample.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/res_sample.c b/tools/perf/ui/browsers/res_sample.c index c0dd73176d42..c450a3536f10 100644 --- a/tools/perf/ui/browsers/res_sample.c +++ b/tools/perf/ui/browsers/res_sample.c @@ -60,7 +60,9 @@ int res_sample_browse(struct res_sample *res_samples, int num_res, return -1; r = &res_samples[choice]; - n = timestamp__scnprintf_nsec(r->time - context_len, trange, sizeof trange); + n = timestamp__scnprintf_nsec(r->time > context_len ? + r->time - context_len : r->time, + trange, sizeof trange); trange[n++] = ','; timestamp__scnprintf_nsec(r->time + context_len, trange + n, sizeof trange - n); -- 2.20.1