From: Steven Rostedt <rostedt@goodmis.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/trace/trace_probe.c - make variable static
Date: Tue, 12 Mar 2019 11:00:44 -0400 [thread overview]
Message-ID: <20190312110044.6fb0e52b@gandalf.local.home> (raw)
In-Reply-To: <2478.1552380778@turing-police>
On Tue, 12 Mar 2019 04:52:58 -0400
"Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
> sparse complains:
> CHECK kernel/trace/trace_probe.c
> kernel/trace/trace_probe.c:16:12: warning: symbol 'reserved_field_names' was not declared. Should it be static?
>
> Yes, it should be static.
Thanks, applied.
Note, I changed the subject to:
tracing/probes: Make reserved_field_names static
To follow the naming convention of the tracing directory.
-- Steve
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 89da34b326e3..cfcf77e6fb19 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -13,7 +13,7 @@
>
> #include "trace_probe.h"
>
> -const char *reserved_field_names[] = {
> +static const char *reserved_field_names[] = {
> "common_type",
> "common_flags",
> "common_preempt_count",
prev parent reply other threads:[~2019-03-12 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 8:52 [PATCH] kernel/trace/trace_probe.c - make variable static Valdis Klētnieks
2019-03-12 15:00 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312110044.6fb0e52b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).