From: Rob Herring <robh@kernel.org>
To: thor.thayer@linux.intel.com
Cc: bp@alien8.de, dinguyen@kernel.org, mark.rutland@arm.com,
mchehab@kernel.org, devicetree@vger.kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2/5] Documentation: dt: edac: Add Stratix10 Peripheral bindings
Date: Tue, 12 Mar 2019 11:04:45 -0500 [thread overview]
Message-ID: <20190312160445.GA8802@bogus> (raw)
In-Reply-To: <1551288445-22335-3-git-send-email-thor.thayer@linux.intel.com>
On Wed, Feb 27, 2019 at 11:27:22AM -0600, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Add peripheral bindings for Stratix10 EDAC to capture
> the differences between the ARM64 and ARM32 architecture.
What's the difference? Sounds like 2 different chips, so Stratix10 or
s10 is not specific enough perhaps.
>
> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> ---
> v2 No change
> ---
> .../devicetree/bindings/edac/socfpga-eccmgr.txt | 106 +++++++++++++++++++++
> 1 file changed, 106 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
> index a0ac50e15912..a0fa80c53d2a 100644
> --- a/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
> +++ b/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
> @@ -258,6 +258,49 @@ Required Properties:
> - compatible : Should be "altr,sdram-edac-s10"
> - interrupts : Should be single bit error interrupt.
>
> +On-Chip RAM ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-ocram-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent OCRAM node.
> +- interrupts : Should be single bit error interrupt.
> +
> +Ethernet FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-eth-mac-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent Ethernet node.
> +- interrupts : Should be single bit error interrupt.
> +
> +NAND FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-nand-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent NAND node.
> +- interrupts : Should be single bit error interrupt.
> +
> +DMA FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-dma-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent DMA node.
> +- interrupts : Should be single bit error interrupt.
> +
> +USB FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-usb-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent USB node.
> +- interrupts : Should be single bit error interrupt.
> +
> +SDMMC FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-s10-sdmmc-ecc"
> +- reg : Address and size for ECC block registers.
> +- altr,ecc-parent : phandle to parent SD/MMC node.
> +- interrupts : Should be single bit error interrupt for port A
> + and then single bit error interrupt for port B.
> +
> Example:
>
> eccmgr {
> @@ -274,4 +317,67 @@ Example:
> compatible = "altr,sdram-edac-s10";
> interrupts = <16 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + ocram-ecc@ff8cc000 {
> + compatible = "altr,socfpga-s10-ocram-ecc";
> + reg = <ff8cc000 0x100>;
> + altr,ecc-parent = <&ocram>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + emac0-rx-ecc@ff8c0000 {
> + compatible = "altr,socfpga-s10-eth-mac-ecc";
> + reg = <0xff8c0000 0x100>;
> + altr,ecc-parent = <&gmac0>;
> + interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + emac0-tx-ecc@ff8c0400 {
> + compatible = "altr,socfpga-s10-eth-mac-ecc";
> + reg = <0xff8c0400 0x100>;
> + altr,ecc-parent = <&gmac0>;
> + interrupts = <5 IRQ_TYPE_LEVEL_HIGH>'
> + };
> +
> + nand-buf-ecc@ff8c8000 {
> + compatible = "altr,socfpga-s10-nand-ecc";
> + reg = <0xff8c8000 0x100>;
> + altr,ecc-parent = <&nand>;
> + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + nand-rd-ecc@ff8c8400 {
> + compatible = "altr,socfpga-s10-nand-ecc";
> + reg = <0xff8c8400 0x100>;
> + altr,ecc-parent = <&nand>;
> + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + nand-wr-ecc@ff8c8800 {
> + compatible = "altr,socfpga-s10-nand-ecc";
> + reg = <0xff8c8800 0x100>;
> + altr,ecc-parent = <&nand>;
> + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + dma-ecc@ff8c9000 {
> + compatible = "altr,socfpga-s10-dma-ecc";
> + reg = <0xff8c9000 0x100>;
> + altr,ecc-parent = <&pdma>;
> + interrupts = <10 IRQ_TYPE_LEVEL_HIGH>;
> +
> + usb0-ecc@ff8c4000 {
> + compatible = "altr,socfpga-s10-usb-ecc";
> + reg = <0xff8c4000 0x100>;
> + altr,ecc-parent = <&usb0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + sdmmc-ecc@ff8c8c00 {
> + compatible = "altr,socfpga-s10-sdmmc-ecc";
> + reg = <0xff8c8c00 0x100>;
> + altr,ecc-parent = <&mmc>;
> + interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,
> + <15 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-03-12 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 17:27 [PATCHv2 0/5] Update Stratix10 EDAC Bindings thor.thayer
2019-02-27 17:27 ` [PATCHv2 1/5] Documentation: dt: edac: Fix Stratix10 IRQ bindings thor.thayer
2019-03-12 16:00 ` Rob Herring
2019-03-12 19:15 ` Thor Thayer
2019-03-13 19:23 ` Rob Herring
2019-02-27 17:27 ` [PATCHv2 2/5] Documentation: dt: edac: Add Stratix10 Peripheral bindings thor.thayer
2019-03-12 16:04 ` Rob Herring [this message]
2019-03-12 19:30 ` Thor Thayer
2019-03-13 19:20 ` Rob Herring
2019-03-15 16:24 ` Thor Thayer
2019-02-27 17:27 ` [PATCHv2 3/5] EDAC, altera: Skip DB IRQ for Stratix10 thor.thayer
2019-02-27 17:27 ` [PATCHv2 4/5] arm64: dts: stratix10: Use new Stratix10 EDAC bindings thor.thayer
2019-02-27 17:27 ` [PATCHv2 5/5] EDAC, altera: Remove Stratix10 Machine compatible check thor.thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312160445.GA8802@bogus \
--to=robh@kernel.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).