From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2] gpu: drm: atomic_helper: Fix spelling errors
Date: Wed, 13 Mar 2019 17:59:36 +0200 [thread overview]
Message-ID: <20190313155936.GM3888@intel.com> (raw)
In-Reply-To: <7b0ff11c-68f3-4e2e-f969-27a14062158e@ideasonboard.com>
On Tue, Mar 12, 2019 at 03:59:15PM +0000, Kieran Bingham wrote:
> Hi Ville,
>
> On 12/03/2019 15:14, Ville Syrjälä wrote:
> > On Tue, Mar 12, 2019 at 12:33:07AM +0000, Kieran Bingham wrote:
> >> Trivial fixes identified while working on the DRM code.
> >>
> >> s/artifically/artificially/
> >> s/achive/achieve/
> >>
> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >> ---
> >>
> >> v2: - Actually spell achieve correctly!
> >
> > drm convention is to put this above the --- so that it gets included in
> > the commit msg.
>
> Oh - in linux-media these are just dropped.
>
> I'll try to remember this for my future work in DRM.
>
> I don't have commit access anyway, so can I presume whomever will pick
> this up will adjust if necessary?
Ah. Yeah, it's fine. Now pushed with the adjustement. Thanks for the
patch.
>
> Or should I repost? (which might be a bit redundant just to move a patch
> version comment which would then increase again :D )
>
>
> > With that
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Thanks,
> --
> Regards
>
> Kieran
>
>
> >
> >>
> >> drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> >> index 540a77a2ade9..2453678d1186 100644
> >> --- a/drivers/gpu/drm/drm_atomic_helper.c
> >> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> >> @@ -1752,7 +1752,7 @@ int drm_atomic_helper_commit(struct drm_device *dev,
> >> *
> >> * NOTE: Commit work has multiple phases, first hardware commit, then
> >> * cleanup. We want them to overlap, hence need system_unbound_wq to
> >> - * make sure work items don't artifically stall on each another.
> >> + * make sure work items don't artificially stall on each another.
> >> */
> >>
> >> drm_atomic_state_get(state);
> >> @@ -1786,7 +1786,7 @@ EXPORT_SYMBOL(drm_atomic_helper_commit);
> >> *
> >> * Asynchronous workers need to have sufficient parallelism to be able to run
> >> * different atomic commits on different CRTCs in parallel. The simplest way to
> >> - * achive this is by running them on the &system_unbound_wq work queue. Note
> >> + * achieve this is by running them on the &system_unbound_wq work queue. Note
> >> * that drivers are not required to split up atomic commits and run an
> >> * individual commit in parallel - userspace is supposed to do that if it cares.
> >> * But it might be beneficial to do that for modesets, since those necessarily
> >> --
> >> 2.19.1
> >
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2019-03-13 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 0:33 [PATCH v2] gpu: drm: atomic_helper: Fix spelling errors Kieran Bingham
2019-03-12 15:14 ` Ville Syrjälä
2019-03-12 15:59 ` Kieran Bingham
2019-03-13 15:59 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313155936.GM3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).