linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	clang-built-linux@googlegroups.com,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	"# 3.4.x" <stable@vger.kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	James Y Knight <jyknight@google.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] lib/string.c: implement a basic bcmp
Date: Wed, 13 Mar 2019 16:12:21 -0400	[thread overview]
Message-ID: <20190313161221.41797313@gandalf.local.home> (raw)
In-Reply-To: <65c69aac-696c-0534-2243-679db926d527@rasmusvillemoes.dk>

On Wed, 13 Mar 2019 20:34:11 +0100
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> Yes, but let's completely avoid mentioning memcmp in the summary.
> 
> bcmp - return 0 if and only if the buffers have identical contents
> @a: pointer to first buffer
> @b: pointer to second buffer
> @len: size of buffers
> 
> The sign or magnitude of a non-zero return value has no particular
> meaning, and architectures may implement their own more efficient
> bcmp(). So while this particular implementation is a simple (tail) call
> to memcmp, do not rely on anything but whether the return value is zero
> or non-zero.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks!

-- Steve

  reply	other threads:[~2019-03-13 20:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 21:52 [PATCH] Makefile: Add '-fno-builtin-bcmp' to CLANG_FLAGS Nathan Chancellor
2019-03-12 22:55 ` Nick Desaulniers
2019-03-13  8:13 ` Rasmus Villemoes
2019-03-13 10:58   ` Masahiro Yamada
2019-03-13 13:44   ` Nathan Chancellor
2019-03-13 13:48     ` Arnd Bergmann
2019-03-13 15:32       ` Nathan Chancellor
2019-03-13 17:21         ` Nick Desaulniers
2019-03-13 17:27           ` Nick Desaulniers
2019-03-13 18:02             ` [PATCH] lib/string.c: implement a basic bcmp Nick Desaulniers
2019-03-13 18:11               ` Nick Desaulniers
2019-03-13 18:17                 ` [PATCH v2] " Nick Desaulniers
2019-03-13 18:40                   ` Steven Rostedt
2019-03-13 18:51                     ` Nick Desaulniers
2019-03-13 19:01                       ` Steven Rostedt
2019-03-13 19:34                         ` Rasmus Villemoes
2019-03-13 20:12                           ` Steven Rostedt [this message]
2019-03-13 20:37                             ` [PATCH v3] " Nick Desaulniers
2019-03-13 21:03                               ` Steven Rostedt
2019-03-13 21:13                                 ` [PATCH v4] " Nick Desaulniers
2019-03-14  3:15                                   ` Nathan Chancellor
2019-03-14  5:00                                   ` Masahiro Yamada
2019-03-14  8:33                                   ` Andy Shevchenko
2019-03-14  9:57                                   ` David Laight
2019-03-14 11:07                                     ` Rasmus Villemoes
2019-03-21  2:11                                   ` Andrew Morton
2019-03-21 17:02                                     ` Nick Desaulniers
2019-03-21 17:20                                       ` Nick Desaulniers
2019-03-21 21:05                                       ` Andrew Morton
2019-03-22  7:17                                       ` Rasmus Villemoes
2019-03-22  7:43                                         ` Sedat Dilek
2019-03-13 19:38             ` [PATCH] Makefile: Add '-fno-builtin-bcmp' to CLANG_FLAGS Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313161221.41797313@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jyknight@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mingo@kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=stable@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).