From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Nikos Tsironis <ntsironis@arrikto.com>,
agk@redhat.com, dm-devel@redhat.com, mpatocka@redhat.com,
iliastsi@arrikto.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers
Date: Wed, 13 Mar 2019 17:25:05 -0700 [thread overview]
Message-ID: <20190314002505.GD13351@linux.ibm.com> (raw)
In-Reply-To: <20190311224333.GA16968@redhat.com>
On Mon, Mar 11, 2019 at 06:43:33PM -0400, Mike Snitzer wrote:
> On Mon, Mar 11 2019 at 6:13pm -0400,
> Paul E. McKenney <paulmck@linux.ibm.com> wrote:
>
> > On Mon, Mar 11, 2019 at 11:16:08AM -0700, Christoph Hellwig wrote:
> > > On Thu, Feb 28, 2019 at 04:32:02PM -0500, Mike Snitzer wrote:
> > > > Hi Paul and Christoph,
> > > >
> > > > You've added your Signed-off-by to include/linux/list_bl.h commits in
> > > > the past. I'm not sure how this proposed patch should be handled.
> > > >
> > > > These new hlist_bl_add_{before,behind} changes are a prereq for
> > > > dm-snapshot changes that Nikos has proposed, please see:
> > > > https://patchwork.kernel.org/patch/10739265/
> > > >
> > > > Any assistance/review you, or others on LKML, might be able to provide
> > > > would be appreciated.
> > >
> > > I just killed two helpers. That being said assuming that we only
> > > rely on the next pointer for the lockless traversals the changes look
> > > fine to me, but the code might be beyond my paygrade..
> >
> > First, apologies for being slow on this one.
>
> No problem.
>
> > Second, were the two helpers hlist_bl_add_{before,behind}()? If so, I
> > guess there is not much point in me looking them over. Though perhaps
> > I should be looking something else over?
>
> No, think Christoph was referring to his commit 1879fd6a26571fd4e8e1f
> from 2011.
>
> Anyway, I'd like you to look over this new proposed patch that
> introduces hlist_bl_add_{before,behind}(), please see:
> https://patchwork.kernel.org/patch/10835713/
>
> If you're happy with the patch, and can provide your Reviewed-by or
> Acked-by, I'll then pick it up as a prereq for the broader dm-snapshot
> changes that Nikos has provided.
I replied to the version earlier in this email thread. Looks close,
but a couple of questions.
Thanx, Paul
next prev parent reply other threads:[~2019-03-14 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181220180651.4879-1-ntsironis@arrikto.com>
[not found] ` <20181220180651.4879-2-ntsironis@arrikto.com>
2019-02-28 21:32 ` [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers Mike Snitzer
2019-02-28 21:34 ` Mike Snitzer
2019-03-11 18:16 ` Christoph Hellwig
2019-03-11 22:13 ` Paul E. McKenney
2019-03-11 22:43 ` Mike Snitzer
2019-03-14 0:25 ` Paul E. McKenney [this message]
2019-03-13 23:48 ` Paul E. McKenney
2019-03-14 0:30 ` Mike Snitzer
2019-03-14 13:28 ` [dm-devel] " Nikos Tsironis
2019-03-14 14:07 ` Paul E. McKenney
2019-03-14 15:03 ` Paul E. McKenney
2019-03-17 11:52 ` Nikos Tsironis
2019-03-18 17:16 ` Paul E. McKenney
2019-03-20 20:25 ` Nikos Tsironis
2019-03-14 17:01 ` Nikos Tsironis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314002505.GD13351@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=iliastsi@arrikto.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=ntsironis@arrikto.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).