From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133B7C43381 for ; Thu, 14 Mar 2019 15:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D73CE20811 for ; Thu, 14 Mar 2019 15:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552578944; bh=FzcosVBjhnbSKqIEcWLnXMxpWUQxNKe647sm5OwKHpU=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=l33puhby4lFGTblGJidiHPmqdbWaUjn2NkFjOofK10k2f7nNYo722bHEM+Eon3g4A zdyIZYK5x9ltzv/Ue4YBqh/0HAct7Gdro3OZPMiGIyh+VW+zF1mmOSryGZ8jZTiRBj RwR1SVC5ZppDPEF0t9+DYBYbhADCuYB4hy/c9HPU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727857AbfCNPzn (ORCPT ); Thu, 14 Mar 2019 11:55:43 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35970 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727581AbfCNPyT (ORCPT ); Thu, 14 Mar 2019 11:54:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=3+0dQHJxtEFZjGNKgNnJRWKMNqsNBYVeEZ/liGzBjRU=; b=JQxwDtGkCjT6 qQazx0pD7gAn2T1uR/5Kv/w5107zxUEpqBN4YrKtpK+Gcns7XYYOvHVV6oY6Npb0Kgd44wQPx6GVn +BRuuNmcMQboSwHFXMYyJXUNthisaTPA9A2Ui/BFN3DJgAoJoV4rdmGfnQIynTeX+HqQJBucW5jx1 Uo6ko=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1h4SgT-0002iu-HL; Thu, 14 Mar 2019 15:54:17 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id E51931126E64; Thu, 14 Mar 2019 15:54:16 +0000 (GMT) From: Mark Brown To: Steve Twiss Cc: Mark Brown , linux-kernel@vger.kernel.org Subject: Applied "regulator: da9211: Fix notifier mutex lock warning" to the regulator tree In-Reply-To: X-Patchwork-Hint: ignore Message-Id: <20190314155416.E51931126E64@debutante.sirena.org.uk> Date: Thu, 14 Mar 2019 15:54:16 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: da9211: Fix notifier mutex lock warning has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 65378de3359d30ebce44762d8b8027f372b5b1c4 Mon Sep 17 00:00:00 2001 From: Steve Twiss Date: Tue, 26 Feb 2019 15:27:57 +0000 Subject: [PATCH] regulator: da9211: Fix notifier mutex lock warning The mutex for the regulator_dev must be controlled by the caller of the regulator_notifier_call_chain(), as described in the comment for that function. Failure to mutex lock and unlock surrounding the notifier call results in a kernel WARN_ON_ONCE() which will dump a backtrace for the regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 1028a37daa14 ("regulator: da9211: new regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss Signed-off-by: Mark Brown --- drivers/regulator/da9211-regulator.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-regulator.c index 109ee12d4362..4d7fe4819c1c 100644 --- a/drivers/regulator/da9211-regulator.c +++ b/drivers/regulator/da9211-regulator.c @@ -322,8 +322,10 @@ static irqreturn_t da9211_irq_handler(int irq, void *data) goto error_i2c; if (reg_val & DA9211_E_OV_CURR_A) { + regulator_lock(chip->rdev[0]); regulator_notifier_call_chain(chip->rdev[0], REGULATOR_EVENT_OVER_CURRENT, NULL); + regulator_unlock(chip->rdev[0]); err = regmap_write(chip->regmap, DA9211_REG_EVENT_B, DA9211_E_OV_CURR_A); @@ -334,8 +336,10 @@ static irqreturn_t da9211_irq_handler(int irq, void *data) } if (reg_val & DA9211_E_OV_CURR_B) { + regulator_lock(chip->rdev[1]); regulator_notifier_call_chain(chip->rdev[1], REGULATOR_EVENT_OVER_CURRENT, NULL); + regulator_unlock(chip->rdev[1]); err = regmap_write(chip->regmap, DA9211_REG_EVENT_B, DA9211_E_OV_CURR_B); -- 2.20.1