linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Volker Haspel <volker.haspel@linutronix.de>
Cc: John Ogness <john.ogness@linutronix.de>,
	Mark Brown <broonie@kernel.org>,
	broonie@kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, han.xu@nxp.com,
	volker.haspel@linutronix.de, john.ogness@linutronix.de,
	linux-spi@vger.kernel.org
Subject: Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree
Date: Thu, 14 Mar 2019 15:54:47 +0000 (GMT)	[thread overview]
Message-ID: <20190314155447.235511126E64@debutante.sirena.org.uk> (raw)
In-Reply-To: <20190312101203.14207-2-volker.haspel@linutronix.de>

The patch

   spi: spi-fsl-qspi: use devm_spi_register_controller

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 8fcb830a00f0980ffe38d223cdd9a4d2d24da476 Mon Sep 17 00:00:00 2001
From: Volker Haspel <volker.haspel@linutronix.de>
Date: Tue, 12 Mar 2019 11:12:03 +0100
Subject: [PATCH] spi: spi-fsl-qspi: use devm_spi_register_controller

The driver does not clearly unregister the spi controller.
Therefore calling an unbind and bind again will end up in a
Kernel crash.

The function devm_spi_register_controller will automatically
be unregister the SPI device.

Signed-off-by: Volker Haspel <volker.haspel@linutronix.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-fsl-qspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 6a713f78a62e..41a49b93ca60 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -882,7 +882,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
 
 	ctlr->dev.of_node = np;
 
-	ret = spi_register_controller(ctlr);
+	ret = devm_spi_register_controller(dev, ctlr);
 	if (ret)
 		goto err_destroy_mutex;
 
-- 
2.20.1


  parent reply	other threads:[~2019-03-14 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 10:12 [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Volker Haspel
2019-03-12 10:12 ` [PATCH v2 1/1] spi: spi-fsl-qspi: use devm_spi_register_controller Volker Haspel
2019-03-13 15:39   ` Applied "spi: spi-fsl-qspi: use devm_spi_register_controller" to the spi tree Mark Brown
2019-03-14 15:54   ` Mark Brown [this message]
2019-03-12 12:24 ` [PATCH v2 0/1] spi: spi-fsl-qspi: call spi_unregister_controller Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314155447.235511126E64@debutante.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=han.xu@nxp.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=volker.haspel@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).