linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Numan Demirdöğen" <if.gnu.linux@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	jason.low2@hpe.com, Waiman.Long@hpe.com,
	paulmck@linux.vnet.ibm.com, tglx@linutronix.de,
	dmitry.torokhov@gmail.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate
Date: Thu, 14 Mar 2019 20:54:51 +0100	[thread overview]
Message-ID: <20190314195451.GC6058@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181218102302.2b029612@korsan.localdomain>

On Tue, Dec 18, 2018 at 10:23:02AM +0300, Numan Demirdöğen wrote:
> I found that passing the options i8042.reset=1 i8042.dumbkbd=1 i8042.direct=1
> results in the keyboard functioning after resume. However, there is a
> long delay before the keyboard or mouse will respond to input on the
> lock screen.[1]

So the thing is, the mutex works, there's nothing wrong or broken about
it (or we'd have known, the kernel would crash and burn). The hand-off
stuff fixed at least one known starvation case as well.

What it does do, is change timing behaviour. But that is something that
is not guaranteed anyway.

This all smells like there's some timing dependent behaviour (aka. race
condition) in the suspend/keyboard interaction _somewhere_.

Now, I know absolutely nothing about either suspend or keyboard stuff,
so I really can't help there. The best idea is to add trace_printk()
throughout the keyboard suspend/resume code and see if there's a clue to
be had there (using remote access to dump the trace buffer after resume,
because of lack of keyboard).

Obviously that takes someone who knows how that should work ...

  reply	other threads:[~2019-03-14 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 18:53 PROBLEM: " Numan Demirdöğen
2018-08-31 19:16 ` Peter Zijlstra
2018-08-31 19:38   ` Numan Demirdöğen
2018-09-03  8:53 ` Numan Demirdöğen
2018-09-18 18:54   ` Pavel Machek
2018-10-19  7:20 ` Fw: " Numan Demirdöğen
2018-10-25  7:49   ` [regression, bisected] " Pavel Machek
2018-10-28 19:06     ` Numan Demirdöğen
2018-11-30 12:44       ` Numan Demirdöğen
2018-12-02 22:28         ` Pavel Machek
2018-12-18  7:23           ` Numan Demirdöğen
2019-03-14 19:54             ` Peter Zijlstra [this message]
2019-07-31  9:07 Numan Demirdöğen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314195451.GC6058@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Waiman.Long@hpe.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=if.gnu.linux@gmail.com \
    --cc=jason.low2@hpe.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=tglx@linutronix.de \
    --subject='Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).