From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Barret Rhoden <brho@google.com>,
Christopher Lameter <cl@linux.com>,
Dennis Zhou <dennis@kernel.org>,
Eial Czerwacki <eial@scalemp.com>,
linux-kernel@vger.kernel.org, Shai Fultheim <shai@scalemp.com>,
Oren Twaig <oren@scalemp.com>
Subject: Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set
Date: Thu, 14 Mar 2019 15:19:43 -0700 [thread overview]
Message-ID: <20190314221943.GQ4102@linux.ibm.com> (raw)
In-Reply-To: <20190314173619.GL50184@devbig004.ftw2.facebook.com>
On Thu, Mar 14, 2019 at 10:36:19AM -0700, Tejun Heo wrote:
> On Wed, Mar 13, 2019 at 04:11:55PM -0700, Paul E. McKenney wrote:
> > commit 34f67df09cc0c6bf082a7cfca435373caeeb8d82
> > Author: Paul E. McKenney <paulmck@linux.ibm.com>
> > Date: Wed Mar 13 16:06:22 2019 -0700
> >
> > srcu: Forbid DEFINE{,_STATIC}_SRCU() from modules
> >
> > Adding DEFINE_SRCU() or DEFINE_STATIC_SRCU() to a loadable module
> > requires that the size of the reserved region be increased, which is
> > not something we want to be doing all that often. Instead, loadable
> > modules should define an srcu_struct and invoke init_srcu_struct()
> > from their module_init function and cleanup_srcu_struct() from their
> > module_exit function. Note that modules using call_srcu() will also
> > need to invoke srcu_barrier() from their module_exit function.
> >
> > This commit enforces this advice by refusing to define DEFINE_SRCU()
> > and DEFINE_STATIC_SRCU() within loadable modules.
> >
> > Suggested-by: Barret Rhoden <brho@google.com>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
>
> Looks-great-to-me-by: Tejun Heo <tj@kernel.org>
Applied. ;-)
Thanx, Paul
> Thanks. :)
>
> --
> tejun
>
next prev parent reply other threads:[~2019-03-14 22:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 11:47 [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set Eial Czerwacki
2019-01-30 10:33 ` Eial Czerwacki
2019-03-01 18:30 ` Barret Rhoden
2019-03-01 20:34 ` Dennis Zhou
2019-03-01 21:27 ` Barret Rhoden
2019-03-01 21:54 ` Christopher Lameter
2019-03-13 19:40 ` Barret Rhoden
2019-03-13 20:26 ` Tejun Heo
2019-03-13 21:22 ` Paul E. McKenney
2019-03-13 21:29 ` Tejun Heo
2019-03-13 23:11 ` Paul E. McKenney
2019-03-14 17:36 ` Tejun Heo
2019-03-14 22:19 ` Paul E. McKenney [this message]
2019-03-18 8:18 ` Eial Czerwacki
2019-03-18 14:27 ` Paul E. McKenney
2019-04-04 20:53 ` Christopher Lameter
2019-03-04 7:42 ` Eial Czerwacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314221943.GQ4102@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=brho@google.com \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=eial@scalemp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oren@scalemp.com \
--cc=shai@scalemp.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).