From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, frankja@linux.ibm.com,
akrowiak@linux.ibm.com, pasic@linux.ibm.com, david@redhat.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
freude@linux.ibm.com, mimu@linux.ibm.com
Subject: Re: [PATCH v5 2/7] s390: ap: new vfio_ap_queue structure
Date: Fri, 15 Mar 2019 11:33:30 +0100 [thread overview]
Message-ID: <20190315113330.5ef0eeef.cohuck@redhat.com> (raw)
In-Reply-To: <1552493104-30510-3-git-send-email-pmorel@linux.ibm.com>
On Wed, 13 Mar 2019 17:04:59 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index e9824c3..df6f21a 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -40,14 +40,42 @@ static struct ap_device_id ap_queue_ids[] = {
>
> MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
>
> +/**
> + * vfio_ap_queue_dev_probe:
> + *
> + * Allocate a vfio_ap_queue structure and associate it
> + * with the device as driver_data.
> + */
> static int vfio_ap_queue_dev_probe(struct ap_device *apdev)
> {
> + struct vfio_ap_queue *q;
> +
> + q = kzalloc(sizeof(*q), GFP_KERNEL);
> + if (!q)
> + return -ENOMEM;
> + dev_set_drvdata(&apdev->device, q);
> + q->apqn = to_ap_queue(&apdev->device)->qid;
> + INIT_LIST_HEAD(&q->list);
> + mutex_lock(&matrix_dev->lock);
> + list_add(&q->list, &matrix_dev->free_list);
> + mutex_unlock(&matrix_dev->lock);
From what I can see, dealing with the free_list is supposed to be
protected by the matrix_dev mutex, and at a glance, it indeed seems to
be held every time you interact with the list. I think it would be good
to document that with a comment.
(I have not reviewed this deeply, and I won't be able to look at this
more until April, sorry.)
> return 0;
> }
next prev parent reply other threads:[~2019-03-15 10:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:04 [PATCH v5 0/7] vfio: ap: AP Queue Interrupt Control Pierre Morel
2019-03-13 16:04 ` [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC Pierre Morel
2019-03-15 10:20 ` Cornelia Huck
2019-03-15 13:26 ` Pierre Morel
2019-03-15 13:41 ` Cornelia Huck
2019-03-15 13:44 ` Pierre Morel
2019-03-15 14:10 ` Pierre Morel
2019-03-15 17:43 ` Halil Pasic
2019-03-19 9:55 ` Pierre Morel
2019-03-15 17:28 ` Halil Pasic
2019-03-19 10:01 ` Pierre Morel
2019-03-19 14:54 ` Halil Pasic
2019-03-19 17:07 ` Pierre Morel
2019-03-21 14:05 ` Pierre Morel
2019-03-13 16:04 ` [PATCH v5 2/7] s390: ap: new vfio_ap_queue structure Pierre Morel
2019-03-15 10:33 ` Cornelia Huck [this message]
2019-03-15 13:29 ` Pierre Morel
2019-03-13 16:05 ` [PATCH v5 3/7] vfio: ap: register IOMMU VFIO notifier Pierre Morel
2019-03-13 16:05 ` [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device Pierre Morel
2019-03-15 18:15 ` Halil Pasic
2019-03-19 9:38 ` Pierre Morel
2019-03-19 11:54 ` Halil Pasic
2019-03-19 14:23 ` Pierre Morel
2019-03-19 14:47 ` Pierre Morel
2019-03-19 15:27 ` Halil Pasic
2019-03-19 16:48 ` Pierre Morel
2019-03-13 16:05 ` [PATCH v5 5/7] s390: ap: implement PAPQ AQIC interception in kernel Pierre Morel
2019-03-13 16:05 ` [PATCH v5 6/7] s390: ap: Cleanup on removing the AP device Pierre Morel
2019-03-13 16:05 ` [PATCH v5 7/7] s390: ap: kvm: Enable PQAP/AQIC facility for the guest Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315113330.5ef0eeef.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).