From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B2AC43381 for ; Fri, 15 Mar 2019 11:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 531A2218C3 for ; Fri, 15 Mar 2019 11:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="qFXb29vL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbfCOLwP (ORCPT ); Fri, 15 Mar 2019 07:52:15 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:35652 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727441AbfCOLwO (ORCPT ); Fri, 15 Mar 2019 07:52:14 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id A00BF25BED4; Fri, 15 Mar 2019 22:52:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1552650731; bh=dwMOCCtY7EjbeQGfbdpYDF5nTdBcV3oKzdGxyA8y24k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qFXb29vLe6exbvFOk+bVrtYOdLjgV1+JEC0j3apjrBNYAdplAD8TwB4AcsdIDo+sR sW8PltBnGCQbFnI5iRr3jdeCclUfJsDS5axV3cbF2Ih7weWuT2H12IzAgFtgRBSkCL zWGkElihErhpMbsJ0rQKCw/gAwXii8OCNHJo8tnc= Received: by reginn.horms.nl (Postfix, from userid 7100) id 02DCC9403F2; Fri, 15 Mar 2019 12:52:09 +0100 (CET) Date: Fri, 15 Mar 2019 12:52:09 +0100 From: Simon Horman To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH 2/3] drm: rcar-du: crtc: make local functions static Message-ID: <20190315115209.7yu5qmzu5h7k264t@verge.net.au> References: <20190314220420.32487-1-kieran.bingham+renesas@ideasonboard.com> <20190314220420.32487-3-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190314220420.32487-3-kieran.bingham+renesas@ideasonboard.com> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 14, 2019 at 10:04:19PM +0000, Kieran Bingham wrote: > The rcar_du_crtc_mode_valid() and rcar_du_crtc_get_crc_sources() > functions are accessed only through a function pointer table. > > Convert the function definitions to be static to the module. > > Signed-off-by: Kieran Bingham Reviewed-by: Simon Horman