From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
Peter Rosin <peda@axentia.se>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Stefan Lengfeld <contact@stefanchrist.eu>,
Phil Reid <preid@electromag.com.au>,
Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/7] i2c: apply coding style for struct i2c_adapter
Date: Fri, 15 Mar 2019 13:15:51 +0100 [thread overview]
Message-ID: <20190315121550.53hhzjy57hndp2w5@verge.net.au> (raw)
In-Reply-To: <20190302134735.4393-2-wsa+renesas@sang-engineering.com>
On Sat, Mar 02, 2019 at 02:47:29PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> include/linux/i2c.h | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 383510b4f083..758a6db864c9 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -517,20 +517,23 @@ i2c_register_board_info(int busnum, struct i2c_board_info const *info,
> * Documentation file Documentation/i2c/fault-codes.
> */
> struct i2c_algorithm {
> - /* If an adapter algorithm can't do I2C-level access, set master_xfer
> - to NULL. If an adapter algorithm can do SMBus access, set
> - smbus_xfer. If set to NULL, the SMBus protocol is simulated
> - using common I2C messages */
> - /* master_xfer should return the number of messages successfully
> - processed, or a negative value on error */
> + /*
> + * If an adapter algorithm can't do I2C-level access, set master_xfer
> + * to NULL. If an adapter algorithm can do SMBus access, set
> + * smbus_xfer. If set to NULL, the SMBus protocol is simulated
> + * using common I2C messages.
> + *
> + * master_xfer should return the number of messages successfully
> + * processed, or a negative value on error
> + */
> int (*master_xfer)(struct i2c_adapter *adap, struct i2c_msg *msgs,
> int num);
> - int (*smbus_xfer) (struct i2c_adapter *adap, u16 addr,
> - unsigned short flags, char read_write,
> - u8 command, int size, union i2c_smbus_data *data);
> + int (*smbus_xfer)(struct i2c_adapter *adap, u16 addr,
> + unsigned short flags, char read_write,
> + u8 command, int size, union i2c_smbus_data *data);
>
> /* To determine what the adapter supports */
> - u32 (*functionality) (struct i2c_adapter *);
> + u32 (*functionality)(struct i2c_adapter *adap);
>
> #if IS_ENABLED(CONFIG_I2C_SLAVE)
> int (*reg_slave)(struct i2c_client *client);
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-03-15 12:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 13:47 [RFC PATCH v2 0/7] i2c: core: introduce atomic transfers Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 1/7] i2c: apply coding style for struct i2c_adapter Wolfram Sang
2019-03-15 12:15 ` Simon Horman [this message]
2019-03-27 13:15 ` Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 2/7] i2c: core: use I2C locking behaviour also for SMBUS Wolfram Sang
2019-03-04 12:35 ` Geert Uytterhoeven
2019-03-15 12:17 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers Wolfram Sang
2019-03-15 12:23 ` Simon Horman
2019-03-27 13:47 ` Wolfram Sang
2019-03-29 9:45 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 4/7] i2c: demux: WIP: handle the new atomic callbacks Wolfram Sang
2019-03-15 12:32 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 5/7] i2c: busses: omap: Add the master_xfer_irqless hook Wolfram Sang
2019-03-15 12:47 ` Simon Horman
2019-03-15 13:14 ` Andy Shevchenko
2019-03-27 13:50 ` Wolfram Sang
2019-03-29 9:45 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 6/7] i2c: tegra-bpmp: convert to use new atomic callbacks Wolfram Sang
2019-03-04 12:25 ` Timo Alho
2019-03-04 12:59 ` Thierry Reding
2019-03-15 12:42 ` Simon Horman
2019-03-26 20:20 ` Stefan Lengfeld
2019-03-27 13:51 ` Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 7/7] i2c: algo: bit: HACK! add atomic callback Wolfram Sang
2019-03-02 16:22 ` [RFC PATCH v2 0/7] i2c: core: introduce atomic transfers Andy Shevchenko
2019-03-12 15:45 ` Wolfram Sang
2019-03-25 13:40 ` Wolfram Sang
2019-03-04 18:11 ` Peter Rosin
2019-03-04 22:48 ` Wolfram Sang
2019-03-07 0:02 ` Peter Rosin
2019-03-27 13:53 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315121550.53hhzjy57hndp2w5@verge.net.au \
--to=horms@verge.net.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=contact@stefanchrist.eu \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).