linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt
@ 2019-03-15 14:58 Alexis Ballier
  2019-03-15 14:58 ` [PATCH 1/3] arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing supplies for bluetooth Alexis Ballier
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Alexis Ballier @ 2019-03-15 14:58 UTC (permalink / raw)
  Cc: Alexis Ballier, devicetree, Heiko Stuebner, linux-arm-kernel,
	linux-rockchip, linux-kernel

This patch series is based on the rockchip/v5.2-armsoc/dts64 branch and
fixes a few mistakes in the rk3399-orangepi.dts I sent a couple weeks ago.

Alexis Ballier (3):
  arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing
    supplies for bluetooth
  arm64: dts: rockchip: rk3399-orangepi: Specify vid supply for the
    compass (AK09911)
  arm64: dts: rockchip: rk3399-orangepi: Add the fusb typec manager

 .../boot/dts/rockchip/rk3399-orangepi.dts     | 31 +++++++++++++++----
 1 file changed, 25 insertions(+), 6 deletions(-)

Cc: devicetree@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org

-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing supplies for bluetooth
  2019-03-15 14:58 [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Alexis Ballier
@ 2019-03-15 14:58 ` Alexis Ballier
  2019-03-15 14:58 ` [PATCH 2/3] arm64: dts: rockchip: rk3399-orangepi: Specify vid supply for the compass (AK09911) Alexis Ballier
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Alexis Ballier @ 2019-03-15 14:58 UTC (permalink / raw)
  Cc: Alexis Ballier, devicetree, Heiko Stuebner, linux-arm-kernel,
	linux-rockchip, linux-kernel

Clock name was wrong, vbat & vddio supplies were missing.

Signed-off-by: Alexis Ballier <aballier@gentoo.org>
Cc: devicetree@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org

---
 arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
index cf37b96a6b77..6bc2e545f2fb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
@@ -707,12 +707,14 @@
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		device-wakeup-gpios = <&gpio2 RK_PD2 GPIO_ACTIVE_HIGH>;
 		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
 		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_reg_on_h>;
+		vbat-supply = <&vcc3v3_sys>;
+		vddio-supply = <&vcc_1v8>;
 	};
 };
 
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] arm64: dts: rockchip: rk3399-orangepi: Specify vid supply for the compass (AK09911)
  2019-03-15 14:58 [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Alexis Ballier
  2019-03-15 14:58 ` [PATCH 1/3] arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing supplies for bluetooth Alexis Ballier
@ 2019-03-15 14:58 ` Alexis Ballier
  2019-03-15 14:58 ` [PATCH 3/3] arm64: dts: rockchip: rk3399-orangepi: Add the fusb typec manager Alexis Ballier
  2019-03-16 19:45 ` [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Heiko Stuebner
  3 siblings, 0 replies; 5+ messages in thread
From: Alexis Ballier @ 2019-03-15 14:58 UTC (permalink / raw)
  Cc: Alexis Ballier, devicetree, Heiko Stuebner, linux-arm-kernel,
	linux-rockchip, linux-kernel

Despite this not being mentioned in the binding documentation, this
generates a log at boot about it being missing.

Signed-off-by: Alexis Ballier <aballier@gentoo.org>
Cc: devicetree@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org

---

Should the binding doc be updated ?
---
 arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
index 6bc2e545f2fb..96ccbe5c4f0c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
@@ -472,6 +472,7 @@
 		compatible = "asahi-kasei,ak09911";
 		reg = <0x0c>;
 		vdd-supply = <&vcc3v3_s3>;
+		vid-supply = <&vcc3v3_s3>;
 	};
 
 	mpu6500@68 {
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] arm64: dts: rockchip: rk3399-orangepi: Add the fusb typec manager
  2019-03-15 14:58 [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Alexis Ballier
  2019-03-15 14:58 ` [PATCH 1/3] arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing supplies for bluetooth Alexis Ballier
  2019-03-15 14:58 ` [PATCH 2/3] arm64: dts: rockchip: rk3399-orangepi: Specify vid supply for the compass (AK09911) Alexis Ballier
@ 2019-03-15 14:58 ` Alexis Ballier
  2019-03-16 19:45 ` [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Heiko Stuebner
  3 siblings, 0 replies; 5+ messages in thread
From: Alexis Ballier @ 2019-03-15 14:58 UTC (permalink / raw)
  Cc: Alexis Ballier, devicetree, Heiko Stuebner, linux-arm-kernel,
	linux-rockchip, linux-kernel

Also rename its regulator to match the schematic names.

Signed-off-by: Alexis Ballier <aballier@gentoo.org>
Cc: devicetree@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org

---
 .../boot/dts/rockchip/rk3399-orangepi.dts     | 26 +++++++++++++++----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
index 96ccbe5c4f0c..2166be171df8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
@@ -136,13 +136,13 @@
 		vin-supply = <&vcc_sys>;
 	};
 
-	vcc5v0_typec0: vcc5v0-typec0-regulator {
+	vbus_typec: vbus-typec-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
 		gpio = <&gpio1 RK_PA3 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
-		pinctrl-0 = <&vcc5v0_typec0_en>;
-		regulator-name = "vcc5v0_typec0";
+		pinctrl-0 = <&vcc5v0_typec_en>;
+		regulator-name = "vbus_typec";
 		vin-supply = <&vcc_sys>;
 	};
 
@@ -505,6 +505,16 @@
 		pinctrl-0 = <&light_int_l>;
 		vdd-supply = <&vcc3v3_s3>;
 	};
+
+	fusb302@22 {
+		compatible = "fcs,fusb302";
+		reg = <0x22>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&chg_cc_int_l>;
+		vbus-supply = <&vbus_typec>;
+	};
 };
 
 &io_domains {
@@ -547,7 +557,7 @@
 				<4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 
-		vcc5v0_typec0_en: vcc5v0-typec0-en {
+		vcc5v0_typec_en: vcc5v0-typec-en {
 			rockchip,pins =
 				<1 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
@@ -596,6 +606,12 @@
 			rockchip,pins = <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
+
+	fusb302 {
+		chg_cc_int_l: chg-cc-int-l {
+			rockchip,pins = <1 RK_PA2 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
 };
 
 &pwm0 {
@@ -677,7 +693,7 @@
 	status = "okay";
 
 	u2phy0_otg: otg-port {
-		phy-supply = <&vcc5v0_typec0>;
+		phy-supply = <&vbus_typec>;
 		status = "okay";
 	};
 
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt
  2019-03-15 14:58 [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Alexis Ballier
                   ` (2 preceding siblings ...)
  2019-03-15 14:58 ` [PATCH 3/3] arm64: dts: rockchip: rk3399-orangepi: Add the fusb typec manager Alexis Ballier
@ 2019-03-16 19:45 ` Heiko Stuebner
  3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2019-03-16 19:45 UTC (permalink / raw)
  To: Alexis Ballier; +Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

Am Freitag, 15. März 2019, 15:58:15 CET schrieb Alexis Ballier:
> This patch series is based on the rockchip/v5.2-armsoc/dts64 branch and
> fixes a few mistakes in the rk3399-orangepi.dts I sent a couple weeks ago.

applied all 3 for 5.2

Thanks
Heiko



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-03-16 19:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 14:58 [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Alexis Ballier
2019-03-15 14:58 ` [PATCH 1/3] arm64: dts: rockchip: rk3399-orangepi: Fix clock names and add missing supplies for bluetooth Alexis Ballier
2019-03-15 14:58 ` [PATCH 2/3] arm64: dts: rockchip: rk3399-orangepi: Specify vid supply for the compass (AK09911) Alexis Ballier
2019-03-15 14:58 ` [PATCH 3/3] arm64: dts: rockchip: rk3399-orangepi: Add the fusb typec manager Alexis Ballier
2019-03-16 19:45 ` [PATCH 0/3] Small improvements/bugfixes to the rk3399-opi dt Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).