From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: linux-nfs@vger.kernel.org,
Anna Schumaker <anna.schumaker@netapp.com>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: mount.nfs: Protocol error after upgrade to linux/master
Date: Fri, 15 Mar 2019 16:54:40 -0700 [thread overview]
Message-ID: <20190315165440.53b9db3c@cakuba.netronome.com> (raw)
In-Reply-To: <20190315120105.5541ad46@cakuba.netronome.com>
On Fri, 15 Mar 2019 12:01:05 -0700, Jakub Kicinski wrote:
> On Fri, 15 Mar 2019 11:05:55 -0700, Jakub Kicinski wrote:
> > Hi,
> >
> > I just upgraded from:
> >
> > commit a3b1933d34d5bb26d7503752e3528315a9e28339 (net)
> > Merge: c6873d18cb4a 24319258660a
> > Author: David S. Miller <davem@davemloft.net>
> > Date: Mon Mar 11 16:22:49 2019 -0700
> >
> > to
> >
> > commit 3b319ee220a8795406852a897299dbdfc1b09911
> > Merge: 9352ca585b2a b6e88119f1ed
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date: Thu Mar 14 10:48:14 2019 -0700
> >
> > and I'm seeing:
> >
> > # mount /home/
> > mount.nfs: Protocol error
> >
> > No errors in dmesg, please let me know if it's a known problem or what
> > other info could be of use.
>
> Hm.. I tried to bisect but reverting to that commit doesn't help.
>
> Looks like the server responds with:
>
> ICMP parameter problem - octet 22, length 80
>
> pointing at some IP options (type 134)...
Okay, figured it out, it's the commit 13e735c0e953 ("LSM: Introduce
CONFIG_LSM") and all the related changes in security/
I did olddefconfig and it changed my security module from apparmor to
smack silently. smack must be slapping those IP options on by default.
Pretty awful user experience, and a non-zero chance that users who
upgrade their kernels will miss this and end up with the wrong security
module...
next parent reply other threads:[~2019-03-15 23:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190315110555.0807d015@cakuba.netronome.com>
[not found] ` <20190315120105.5541ad46@cakuba.netronome.com>
2019-03-15 23:54 ` Jakub Kicinski [this message]
2019-03-16 5:24 ` mount.nfs: Protocol error after upgrade to linux/master Kees Cook
2019-03-16 5:38 ` Kees Cook
2019-03-16 8:08 ` Tetsuo Handa
2019-03-17 1:02 ` Casey Schaufler
2019-03-19 10:56 ` Tetsuo Handa
2019-03-19 15:03 ` Casey Schaufler
2019-03-21 16:38 ` Kees Cook
2019-03-21 21:10 ` Tetsuo Handa
2019-03-22 22:45 ` Kees Cook
2019-03-23 2:44 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315165440.53b9db3c@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=anna.schumaker@netapp.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).