From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63113C43381 for ; Fri, 15 Mar 2019 17:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BC82218AC for ; Fri, 15 Mar 2019 17:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="iugyRz08" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbfCORhY (ORCPT ); Fri, 15 Mar 2019 13:37:24 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53096 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfCORhX (ORCPT ); Fri, 15 Mar 2019 13:37:23 -0400 Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2A50C1EC05A1; Fri, 15 Mar 2019 18:37:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1552671442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=c+Nd2opdnaoNL2UZp6sWhw6kLnu3C7DcLwikpyUuZlM=; b=iugyRz08q0F02RkVBPFYlJgODX8OAv4eIMP90ovmBi0bi3sz9NR+W0JKlkRCm+6bT3EuML Mkg77RA0aVMKK8kqL11DQpfmEE+OnN3lPPrEuVdC86B1ZhIF2qtt3bicadHn8owb0+3Cdm bx9eJ5BKsBvHNeMn85MWZlN+AR8znCw= Date: Fri, 15 Mar 2019 18:37:20 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Arnd Bergmann , Mauro Carvalho Chehab , James Morse , Qiuxu Zhuo , linux-edac@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error Message-ID: <20190315173720.GC12523@zn.tnic> References: <20190305143453.GC8256@zn.tnic> <20190306175808.GA30016@agluck-desk> <20190313230137.GA12529@agluck-desk> <20190314110413.GA32277@zn.tnic> <20190314215952.GA303@agluck-desk> <20190315094341.GA12523@zn.tnic> <20190315155718.GA17775@agluck-desk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190315155718.GA17775@agluck-desk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 08:57:18AM -0700, Luck, Tony wrote: > fsl_ddr_edac.c looks to be doing exactly what we are doing with > skx_common.c. They just get away with it for now because they don't > have a reference to THIS_MODULE since they don't set up anything > in sysfs. > > If this is your goal, then Qiuxu's patch that moves the problem > piece out of skx_common.c does what you are asking for. My goal is to not make it too complex and this way burden future maintainability, without introducing the craziest randconfig build fixes. I think the shared code should not have any reference to modules because it is supposed to be a library. Can you move the THIS_MODULE out of the common file and into the actual module? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.