From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3328C43381 for ; Fri, 15 Mar 2019 18:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98BE32186A for ; Fri, 15 Mar 2019 18:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727255AbfCOSLm (ORCPT ); Fri, 15 Mar 2019 14:11:42 -0400 Received: from mga12.intel.com ([192.55.52.136]:44495 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfCOSLl (ORCPT ); Fri, 15 Mar 2019 14:11:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 11:11:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,483,1544515200"; d="scan'208";a="131977047" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga008.fm.intel.com with ESMTP; 15 Mar 2019 11:11:34 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h4rIc-0003Ck-FI; Fri, 15 Mar 2019 20:11:18 +0200 Date: Fri, 15 Mar 2019 20:11:18 +0200 From: Andy Shevchenko To: "Enrico Weigelt, metux IT consult" Cc: "Enrico Weigelt, metux IT consult" , Linux Kernel Mailing List , Greg Kroah-Hartman , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Vladimir Zapolskiy , Matthias Brugger , Masahiro Yamada , Tobias Klauser , Richard Genoud , macro@linux-mips.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sascha Hauer , slemieux.tyco@gmail.com, Andy Gross , David Brown , Shawn Guo , Sascha Hauer , Fabio Estevam , dl-linux-imx , baohua@kernel.org, Peter Korsgaard , "open list:SERIAL DRIVERS" , linux-arm-msm@vger.kernel.org, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" Subject: Re: serial driver cleanups v2 Message-ID: <20190315181118.GF9224@smile.fi.intel.com> References: <1552602855-26086-1-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 11:36:04AM +0100, Enrico Weigelt, metux IT consult wrote: > On 15.03.19 10:12, Andy Shevchenko wrote: > > >> Part II will be about moving the mmio range from mapbase and > >> mapsize (which are used quite inconsistently) to a struct resource > >> and using helpers for that. But this one isn't finished yet. > >> (if somebody likes to have a look at it, I can send it, too) > > > > Let's do that way you are preparing a branch somewhere and anounce > > here as an RFC, since this was neither tested nor correct. > > Okay, here it is: > > I. https://github.com/metux/linux/tree/submit/serial-clean-v3 > --> general cleanups, as basis for II > > II. https://github.com/metux/linux/tree/wip/serial-res > --> moving towards using struct resource consistently > > III. https://github.com/metux/linux/tree/hack/serial > --> the final steps, which are yet completely broken > (more a notepad for things still to do :o) > > The actual goal is generalizing the whole iomem handling, so individual > usually just need to call some helpers that do most of the things. > Finally, I also wanted to have all io region information consolidated > in struct resource. That's should be a selling point, not just conversion per se. > > And selling point for many of them is not true: it doesn't make any > > difference in the size in code, but increases a time to run > > (devm_ioremap_resource() does more than plain devm_iomap() call). > > Okay, just seen it. Does the the runtime overhead cause any problems ? You have to explain that in each commit message, that the change does bring a possible new error message printed. The performance side of the deal, you are lucky here, is not significant because it's slow path. -- With Best Regards, Andy Shevchenko