From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29349C43381 for ; Fri, 15 Mar 2019 19:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB14C2186A for ; Fri, 15 Mar 2019 19:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbfCOT4j (ORCPT ); Fri, 15 Mar 2019 15:56:39 -0400 Received: from mga05.intel.com ([192.55.52.43]:26446 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfCOT4j (ORCPT ); Fri, 15 Mar 2019 15:56:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 12:56:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,483,1544515200"; d="scan'208";a="134722102" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga007.fm.intel.com with ESMTP; 15 Mar 2019 12:56:36 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h4swV-0004X8-77; Fri, 15 Mar 2019 21:56:35 +0200 Date: Fri, 15 Mar 2019 21:56:35 +0200 From: Andy Shevchenko To: Andrey Abramov Cc: Geert Uytterhoeven , George Spelvin , Andrew Morton , Daniel Wagner , Dave Chinner , Don Mullis , Linux Kernel Mailing List , Rasmus Villemoes Subject: Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS Message-ID: <20190315195635.GI9224@smile.fi.intel.com> References: <20190314091041.GU9224@smile.fi.intel.com> <201903150433.x2F4X9oT024601@sdf.org> <201903151023.x2FANDVY013031@sdf.org> <201903151659.x2FGxi3R012970@sdf.org> <23331552675987@myt2-66bcb87429e6.qloud-c.yandex.net> <20190315190614.GH9224@smile.fi.intel.com> <69031552677833@myt1-e20b74e6250c.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69031552677833@myt1-e20b74e6250c.qloud-c.yandex.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 10:23:53PM +0300, Andrey Abramov wrote: > 15.03.2019, 22:06, "Andy Shevchenko" : > > It makes harder to read and understand the code. One needs spend deciseconds / > > seconds to catch instead of santiseconds of time. > > If it is true for someone (for example, for me it is almost as readable > as a simple size_t), then I agree with Geert who said: "use size_t everywhere". We already spent too much on bikeshedding here. -- With Best Regards, Andy Shevchenko