From: Vinod Koul <vkoul@kernel.org>
To: Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>
Cc: maxime.ripard@bootlin.com, wens@csie.org, robh+dt@kernel.org,
mark.rutland@arm.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller
Date: Sat, 16 Mar 2019 16:27:11 +0530 [thread overview]
Message-ID: <20190316105711.GG5348@vkoul-mobl> (raw)
In-Reply-To: <20190307165829.9086-2-jernej.skrabec@siol.net>
On 07-03-19, 17:58, Jernej Skrabec wrote:
> DMA in H6 is similar to other DMA controller, except it is first which
> supports more than 32 request sources and has 16 channels. It also needs
> additional clock to be enabled.
Please see DT folks on this patch, when in doubt, use get_maintainers.pl
Need an ack on this patch before applying
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
> Documentation/devicetree/bindings/dma/sun6i-dma.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> index 7fccc20d8331..cae31f4e77ba 100644
> --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> @@ -28,12 +28,17 @@ Example:
> };
>
> ------------------------------------------------------------------------------
> -For A64 DMA controller:
> +For A64 and H6 DMA controller:
>
> Required properties:
> -- compatible: "allwinner,sun50i-a64-dma"
> +- compatible: Must be one of
> + "allwinner,sun50i-a64-dma"
> + "allwinner,sun50i-h6-dma"
> - dma-channels: Number of DMA channels supported by the controller.
> Refer to Documentation/devicetree/bindings/dma/dma.txt
> +- clocks: In addition to parent AHB clock, it should also contain mbus
> + clock (H6 only)
> +- clock-names: Should contain "bus" and "mbus" (H6 only)
> - all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells
>
> Optional properties:
> --
> 2.21.0
--
~Vinod
next prev parent reply other threads:[~2019-03-16 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 16:58 [PATCH 0/6] Allwinner H6 DMA support Jernej Skrabec
2019-03-07 16:58 ` [PATCH 1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller Jernej Skrabec
2019-03-16 10:57 ` Vinod Koul [this message]
2019-03-16 11:27 ` Jernej Škrabec
2019-03-27 23:47 ` Rob Herring
2019-03-07 16:58 ` [PATCH 2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Jernej Skrabec
2019-03-11 5:47 ` Chen-Yu Tsai
2019-03-16 11:07 ` Vinod Koul
2019-03-16 11:23 ` Jernej Škrabec
2019-03-22 12:59 ` Vinod Koul
2019-03-22 13:03 ` Maxime Ripard
2019-03-07 16:58 ` [PATCH 3/6] dmaengine: sun6i: Add a quirk for setting DRQ fields Jernej Skrabec
2019-03-07 16:58 ` [PATCH 4/6] dmaengine: sun6i: Add a quirk for setting mode fields Jernej Skrabec
2019-03-07 16:58 ` [PATCH 5/6] dmaengine: sun6i: Add support for H6 DMA Jernej Skrabec
2019-03-16 11:13 ` Vinod Koul
2019-03-16 11:37 ` Jernej Škrabec
2019-03-07 16:58 ` [PATCH 6/6] arm64: dts: allwinner: h6: Add DMA node Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316105711.GG5348@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).