From: Roman Gushchin <guroan@gmail.com>
To: Tejun Heo <tj@kernel.org>, Oleg Nesterov <oleg@redhat.com>
Cc: Roman Gushchin <guro@fb.com>,
kernel-team@fb.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: [PATCH v9 5/9] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy()
Date: Sat, 16 Mar 2019 10:58:08 -0700 [thread overview]
Message-ID: <20190316175812.6787-6-guro@fb.com> (raw)
In-Reply-To: <20190316175812.6787-1-guro@fb.com>
If the cgroup destruction races with an exit() of a belonging
process(es), cg_kill_all() may fail. It's not a good reason to make
cg_destroy() fail and leave the cgroup in place, potentially causing
next test runs to fail.
Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: kernel-team@fb.com
Cc: linux-kselftest@vger.kernel.org
---
tools/testing/selftests/cgroup/cgroup_util.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index 14c9fe284806..eba06f94433b 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup)
retry:
ret = rmdir(cgroup);
if (ret && errno == EBUSY) {
- ret = cg_killall(cgroup);
- if (ret)
- return ret;
+ cg_killall(cgroup);
usleep(100);
goto retry;
}
--
2.20.1
next prev parent reply other threads:[~2019-03-16 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 17:58 [PATCH v9 0/9] freezer for cgroup v2 Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 1/9] cgroup: rename freezer.c into legacy_freezer.c Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 2/9] cgroup: implement __cgroup_task_count() helper Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 3/9] cgroup: protect cgroup->nr_(dying_)descendants by css_set_lock Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 4/9] cgroup: cgroup v2 freezer Roman Gushchin
2019-04-02 16:02 ` Oleg Nesterov
2019-04-02 22:08 ` Roman Gushchin
2019-03-16 17:58 ` Roman Gushchin [this message]
2019-03-16 17:58 ` [PATCH v9 6/9] kselftests: cgroup: add freezer controller self-tests Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 7/9] cgroup: make TRACE_CGROUP_PATH irq-safe Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 8/9] cgroup: add tracing points for cgroup v2 freezer Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 9/9] cgroup: document cgroup v2 freezer interface Roman Gushchin
2019-03-25 16:59 ` [PATCH v9 0/9] freezer for cgroup v2 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316175812.6787-6-guro@fb.com \
--to=guroan@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).