From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jose Abreu <jose.abreu@synopsys.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Joao Pinto <joao.pinto@synopsys.com>
Subject: Re: [PATCH net] net: phy: Don't assume loopback is supported
Date: Sun, 17 Mar 2019 19:38:43 +0100 [thread overview]
Message-ID: <20190317183843.GE22226@lunn.ch> (raw)
In-Reply-To: <19c8d2b3-bffe-b3b2-6e91-e878f89e5247@gmail.com>
On Fri, Mar 15, 2019 at 03:48:41PM -0700, Florian Fainelli wrote:
> On 3/14/19 3:37 AM, Jose Abreu wrote:
> > Some PHYs may not support loopback mode so we need to check if register
> > is read-only.
> >
>
> In that case it may be appropriate to have a specific PHY driver that
> implements a set_loopback() method returning -EOPNOTSUPP instead of
> changing the generic PHY implementation.
Hi Jose
Since Heiner says this is a mandatory feature, we should not really
penalise conformant PHYs just because there is one broken PHY.
Please handle this in the PHY driver, by implementing the set_loopback
call.
Andrew
next prev parent reply other threads:[~2019-03-17 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 10:37 [PATCH net] net: phy: Don't assume loopback is supported Jose Abreu
2019-03-15 22:43 ` David Miller
2019-03-15 22:48 ` Florian Fainelli
2019-03-17 18:38 ` Andrew Lunn [this message]
2019-03-18 12:46 ` Jose Abreu
2019-03-18 14:19 ` Andrew Lunn
2019-03-15 23:14 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317183843.GE22226@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).