From: Michal Hocko <mhocko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Richard Biener <rguenther@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: Kernel bug with MPX?
Date: Mon, 18 Mar 2019 12:47:03 +0100 [thread overview]
Message-ID: <20190318114703.GE8924@dhcp22.suse.cz> (raw)
In-Reply-To: <ec2110b1-abae-4df5-fcd7-244620634a00@intel.com>
On Thu 14-03-19 09:51:42, Dave Hansen wrote:
[...]
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> MPX is being removed from the kernel due to a lack of support
> in the toolchain going forward (gcc).
>
> The first thing we need to do is remove the userspace-visible
> ABIs so that applications will stop using it. The most visible
> one are the enable/disable prctl()s. Remove them first.
>
> This is the most minimal and least invasive patch needed to
> start removing MPX.
Is this something we _want_ to push to stable trees?
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> ---
>
> b/include/uapi/linux/prctl.h | 2 +-
> b/kernel/sys.c | 16 ++--------------
> 2 files changed, 3 insertions(+), 15 deletions(-)
>
> diff -puN include/uapi/linux/prctl.h~mpx-remove-apis include/uapi/linux/prctl.h
> --- a/include/uapi/linux/prctl.h~mpx-remove-apis 2019-01-04 14:40:06.853514089 -0800
> +++ b/include/uapi/linux/prctl.h 2019-01-04 14:40:06.860514089 -0800
> @@ -181,7 +181,7 @@ struct prctl_mm_map {
> #define PR_GET_THP_DISABLE 42
>
> /*
> - * Tell the kernel to start/stop helping userspace manage bounds tables.
> + * No longer implemented, but left here to ensure the numbers stay reserved:
> */
> #define PR_MPX_ENABLE_MANAGEMENT 43
> #define PR_MPX_DISABLE_MANAGEMENT 44
> diff -puN kernel/sys.c~mpx-remove-apis kernel/sys.c
> --- a/kernel/sys.c~mpx-remove-apis 2019-01-04 14:40:06.857514089 -0800
> +++ b/kernel/sys.c 2019-01-04 14:40:06.860514089 -0800
> @@ -103,12 +103,6 @@
> #ifndef SET_TSC_CTL
> # define SET_TSC_CTL(a) (-EINVAL)
> #endif
> -#ifndef MPX_ENABLE_MANAGEMENT
> -# define MPX_ENABLE_MANAGEMENT() (-EINVAL)
> -#endif
> -#ifndef MPX_DISABLE_MANAGEMENT
> -# define MPX_DISABLE_MANAGEMENT() (-EINVAL)
> -#endif
> #ifndef GET_FP_MODE
> # define GET_FP_MODE(a) (-EINVAL)
> #endif
> @@ -2448,15 +2442,9 @@ SYSCALL_DEFINE5(prctl, int, option, unsi
> up_write(&me->mm->mmap_sem);
> break;
> case PR_MPX_ENABLE_MANAGEMENT:
> - if (arg2 || arg3 || arg4 || arg5)
> - return -EINVAL;
> - error = MPX_ENABLE_MANAGEMENT();
> - break;
> case PR_MPX_DISABLE_MANAGEMENT:
> - if (arg2 || arg3 || arg4 || arg5)
> - return -EINVAL;
> - error = MPX_DISABLE_MANAGEMENT();
> - break;
> + /* No longer implemented: */
> + return -EINVAL;
> case PR_SET_FP_MODE:
> error = SET_FP_MODE(me, arg2);
> break;
> _
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-03-18 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 8:53 Kernel bug with MPX? Richard Biener
2019-03-07 20:38 ` Dave Hansen
2019-03-08 7:12 ` Michal Hocko
2019-03-08 7:41 ` Michal Hocko
2019-03-13 22:00 ` Dave Hansen
2019-03-14 16:51 ` Dave Hansen
2019-03-18 11:47 ` Michal Hocko [this message]
2019-03-18 15:59 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318114703.GE8924@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rguenther@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).