linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: Remove no longer used console_silent().
Date: Mon, 18 Mar 2019 23:34:21 +0900	[thread overview]
Message-ID: <20190318143421.GB29374@tigerII.localdomain> (raw)
In-Reply-To: <1552917923-16601-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On (03/18/19 23:05), Tetsuo Handa wrote:
> console_silent() is no longer used after the removal of
> arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.

[..]

> -static inline void console_silent(void)
> -{
> -	console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> -}

I would keep it, I guess, and would instead covert

kernel/debug/kdb/kdb_io.c:              console_loglevel = CONSOLE_LOGLEVEL_SILENT

to use proper API (console_silent()).

	-ss

  reply	other threads:[~2019-03-18 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 14:05 [PATCH] printk: Remove no longer used console_silent() Tetsuo Handa
2019-03-18 14:34 ` Sergey Senozhatsky [this message]
2019-03-20 14:39   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318143421.GB29374@tigerII.localdomain \
    --to=sergey.senozhatsky@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).