* [PATCH net-next] datagram: Make __skb_datagram_iter static
@ 2019-03-19 14:59 Yue Haibing
2019-03-19 16:43 ` Sagi Grimberg
2019-03-19 21:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-19 14:59 UTC (permalink / raw)
To: davem, sagi, xiyou.wangcong, kgraul; +Cc: linux-kernel, netdev, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
net/core/datagram.c:411:5: warning:
symbol '__skb_datagram_iter' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/core/datagram.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/core/datagram.c b/net/core/datagram.c
index b2651bb..ed8accb 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -408,10 +408,10 @@ int skb_kill_datagram(struct sock *sk, struct sk_buff *skb, unsigned int flags)
}
EXPORT_SYMBOL(skb_kill_datagram);
-int __skb_datagram_iter(const struct sk_buff *skb, int offset,
- struct iov_iter *to, int len, bool fault_short,
- size_t (*cb)(const void *, size_t, void *, struct iov_iter *),
- void *data)
+static int __skb_datagram_iter(const struct sk_buff *skb, int offset,
+ struct iov_iter *to, int len, bool fault_short,
+ size_t (*cb)(const void *, size_t, void *,
+ struct iov_iter *), void *data)
{
int start = skb_headlen(skb);
int i, copy = start - offset, start_off = offset, n;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] datagram: Make __skb_datagram_iter static
2019-03-19 14:59 [PATCH net-next] datagram: Make __skb_datagram_iter static Yue Haibing
@ 2019-03-19 16:43 ` Sagi Grimberg
2019-03-19 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2019-03-19 16:43 UTC (permalink / raw)
To: Yue Haibing, davem, xiyou.wangcong, kgraul; +Cc: linux-kernel, netdev
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] datagram: Make __skb_datagram_iter static
2019-03-19 14:59 [PATCH net-next] datagram: Make __skb_datagram_iter static Yue Haibing
2019-03-19 16:43 ` Sagi Grimberg
@ 2019-03-19 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-03-19 21:12 UTC (permalink / raw)
To: yuehaibing; +Cc: sagi, xiyou.wangcong, kgraul, linux-kernel, netdev
From: Yue Haibing <yuehaibing@huawei.com>
Date: Tue, 19 Mar 2019 22:59:46 +0800
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> net/core/datagram.c:411:5: warning:
> symbol '__skb_datagram_iter' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-19 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:59 [PATCH net-next] datagram: Make __skb_datagram_iter static Yue Haibing
2019-03-19 16:43 ` Sagi Grimberg
2019-03-19 21:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).