linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sh: mm: make use of new memblocks_present() helper
@ 2019-03-19 18:09 Logan Gunthorpe
  2019-03-19 20:39 ` Mike Rapoport
  0 siblings, 1 reply; 3+ messages in thread
From: Logan Gunthorpe @ 2019-03-19 18:09 UTC (permalink / raw)
  To: linux-sh, linux-kernel
  Cc: Andrew Morton, Mike Rapoport, Michal Hocko, Logan Gunthorpe,
	Christoph Hellwig, Yoshinori Sato, Rich Felker

Cleanup the open coded for_each_memblock() loop that is equivalent
to the new memblocks_present() helper.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
---
 arch/sh/mm/init.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

This is just a resend

diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
index a8e5c0e00fca..dc0ff41d602d 100644
--- a/arch/sh/mm/init.c
+++ b/arch/sh/mm/init.c
@@ -234,12 +234,7 @@ static void __init do_init_bootmem(void)

 	plat_mem_setup();

-	for_each_memblock(memory, reg) {
-		int nid = memblock_get_region_node(reg);
-
-		memory_present(nid, memblock_region_memory_base_pfn(reg),
-			memblock_region_memory_end_pfn(reg));
-	}
+	memblocks_present();
 	sparse_init();
 }

--
2.19.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sh: mm: make use of new memblocks_present() helper
  2019-03-19 18:09 [PATCH] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
@ 2019-03-19 20:39 ` Mike Rapoport
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2019-03-19 20:39 UTC (permalink / raw)
  To: Logan Gunthorpe
  Cc: linux-sh, linux-kernel, Andrew Morton, Michal Hocko,
	Christoph Hellwig, Yoshinori Sato, Rich Felker

On Tue, Mar 19, 2019 at 12:09:30PM -0600, Logan Gunthorpe wrote:
> Cleanup the open coded for_each_memblock() loop that is equivalent
> to the new memblocks_present() helper.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  arch/sh/mm/init.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> This is just a resend
> 
> diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
> index a8e5c0e00fca..dc0ff41d602d 100644
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -234,12 +234,7 @@ static void __init do_init_bootmem(void)
> 
>  	plat_mem_setup();
> 
> -	for_each_memblock(memory, reg) {
> -		int nid = memblock_get_region_node(reg);
> -
> -		memory_present(nid, memblock_region_memory_base_pfn(reg),
> -			memblock_region_memory_end_pfn(reg));
> -	}
> +	memblocks_present();
>  	sparse_init();
>  }
> 
> --
> 2.19.0
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] sh: mm: make use of new memblocks_present() helper
@ 2019-01-15 17:37 Logan Gunthorpe
  0 siblings, 0 replies; 3+ messages in thread
From: Logan Gunthorpe @ 2019-01-15 17:37 UTC (permalink / raw)
  To: linux-sh, linux-kernel, Yoshinori Sato, Rich Felker; +Cc: Logan Gunthorpe

Cleanup the open coded for_each_memblock() loop that is equivalent
to the new memblocks_present() helper.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
---
 arch/sh/mm/init.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
index a8e5c0e00fca..dc0ff41d602d 100644
--- a/arch/sh/mm/init.c
+++ b/arch/sh/mm/init.c
@@ -234,12 +234,7 @@ static void __init do_init_bootmem(void)
 
 	plat_mem_setup();
 
-	for_each_memblock(memory, reg) {
-		int nid = memblock_get_region_node(reg);
-
-		memory_present(nid, memblock_region_memory_base_pfn(reg),
-			memblock_region_memory_end_pfn(reg));
-	}
+	memblocks_present();
 	sparse_init();
 }
 
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-19 20:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 18:09 [PATCH] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
2019-03-19 20:39 ` Mike Rapoport
  -- strict thread matches above, loose matches on Subject: below --
2019-01-15 17:37 Logan Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).