From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251CBC43381 for ; Tue, 19 Mar 2019 22:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAD2E2075C for ; Tue, 19 Mar 2019 22:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553035915; bh=afqATXa6VUi3X8fpjJpqxUx8gMhO931y0UVyfUkeuv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VLgAOGP6VyiH/azRgSmMgF510LUDzOs5BLX02aXtCbHlMKoYQQ10UADvbxH9WZNaE GKCNzxEvNkzHA97KEywZPtB5tczuTfB8PNxejrHMiGq8wmSDF8NEzOKBQTrvGelIJA EZuWDQ0wEzJFTTdlRtPxD5BuRIBRXQA5EYEOPMtU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727116AbfCSWvx (ORCPT ); Tue, 19 Mar 2019 18:51:53 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34450 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726823AbfCSWvx (ORCPT ); Tue, 19 Mar 2019 18:51:53 -0400 Received: by mail-pf1-f195.google.com with SMTP id v64so436162pfb.1; Tue, 19 Mar 2019 15:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yAp+q49agDeOxIr3K1jrtyVFou1CeqqLCoEHJhnF1yg=; b=udGtqzg6Pe5kqOYN7GgQkm+Qaycc3mRpNgQ9FbYKZnQEXNG9W19HZsAoiNJ7Iow3Av 608Sk43rqb8eo0zB5PRDYeaC3NpHccL/cZeXxuc8F0f9rnDs6KAVNJZWY0mpjB5tB0X5 ye/zPST7ir902ux1ERoubm4t4b13T+fHN4hJepx19epv6YQG6M989fVCLSlPmib+7Lt5 bSDvqtK7f5Wqxw+WNVOyVkZ3W0Z6QOmt0w5svukcQ0nDZ/lLKz0DH/G6PAmPQq2E0KIK YbRroR0swYibF7GHXcvWY3/jL/n4AEWqSkNFUq3wzwTvRY6dl1J5vkbDiW4T2aXprONQ tVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yAp+q49agDeOxIr3K1jrtyVFou1CeqqLCoEHJhnF1yg=; b=BHsWg/lbEW06VfSI7EULp/PGXAB0mjxd6DjUGY0h2faQg/sSVIWaaT250XUPAkZzuP fE3ogqVoomRBGjfwmT7o1hMp9TSqc0qiayiPfoigU4Szq9vdgd3bCoXtDWb9EDG7tP6P JBgPVDz4mjrlAfg1z/eBVLjCfkVZ5PD9FdxLI/BdyMcBBvdrjm8qRSXqhbEkxHjKMUsw o0mY8eVA4l7o4oRPZTUYZY+RQGtprREykFn0+aCM4oObQvT4n1VGMQ2ipqU5tLJYIcoS JnejMzBOO5+8+nE8AE6TwLM1F9X5Sd5lso1Dxlmjf8R9+pqu67/YFRjHQtdzkn1nFjbz tJ5Q== X-Gm-Message-State: APjAAAWQJNxvLblJ9Or1znS8kQE/Th6TrPA/PqTWpOuuZYS0uVC08vim RhSjBNwhSyu4GJ4Wy8HbhGM= X-Google-Smtp-Source: APXvYqxpBYZHXxI5ZiAmYBj4YPdhgYj3d3yenCYxuh9NFKurrYb21G7Nc9d0OjGpLdE+ntSPhjFEJQ== X-Received: by 2002:a17:902:ea8c:: with SMTP id cv12mr4814581plb.123.1553035911561; Tue, 19 Mar 2019 15:51:51 -0700 (PDT) Received: from google.com ([2401:fa00:d:0:98f1:8b3d:1f37:3e8]) by smtp.gmail.com with ESMTPSA id z15sm82620pgc.25.2019.03.19.15.51.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 15:51:50 -0700 (PDT) Date: Wed, 20 Mar 2019 07:51:44 +0900 From: Minchan Kim To: Suren Baghdasaryan Cc: gregkh@linuxfoundation.org, tj@kernel.org, lizefan@huawei.com, hannes@cmpxchg.org, axboe@kernel.dk, dennis@kernel.org, dennisszhou@gmail.com, mingo@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v5 0/7] psi: pressure stall monitors v5 Message-ID: <20190319225144.GA80186@google.com> References: <20190308184311.144521-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308184311.144521-1-surenb@google.com> User-Agent: Mutt/1.10.1+60 (6df12dc1) (2018-08-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 08, 2019 at 10:43:04AM -0800, Suren Baghdasaryan wrote: > This is respin of: > https://lwn.net/ml/linux-kernel/20190206023446.177362-1-surenb%40google.com/ > > Android is adopting psi to detect and remedy memory pressure that > results in stuttering and decreased responsiveness on mobile devices. > > Psi gives us the stall information, but because we're dealing with > latencies in the millisecond range, periodically reading the pressure > files to detect stalls in a timely fashion is not feasible. Psi also > doesn't aggregate its averages at a high-enough frequency right now. > > This patch series extends the psi interface such that users can > configure sensitive latency thresholds and use poll() and friends to > be notified when these are breached. > > As high-frequency aggregation is costly, it implements an aggregation > method that is optimized for fast, short-interval averaging, and makes > the aggregation frequency adaptive, such that high-frequency updates > only happen while monitored stall events are actively occurring. > > With these patches applied, Android can monitor for, and ward off, > mounting memory shortages before they cause problems for the user. > For example, using memory stall monitors in userspace low memory > killer daemon (lmkd) we can detect mounting pressure and kill less > important processes before device becomes visibly sluggish. In our > memory stress testing psi memory monitors produce roughly 10x less > false positives compared to vmpressure signals. Having ability to > specify multiple triggers for the same psi metric allows other parts > of Android framework to monitor memory state of the device and act > accordingly. > > The new interface is straight-forward. The user opens one of the > pressure files for writing and writes a trigger description into the > file descriptor that defines the stall state - some or full, and the > maximum stall time over a given window of time. E.g.: > > /* Signal when stall time exceeds 100ms of a 1s window */ > char trigger[] = "full 100000 1000000" > fd = open("/proc/pressure/memory") > write(fd, trigger, sizeof(trigger)) > while (poll() >= 0) { > ... > }; > close(fd); > > When the monitored stall state is entered, psi adapts its aggregation > frequency according to what the configured time window requires in > order to emit event signals in a timely fashion. Once the stalling > subsides, aggregation reverts back to normal. > > The trigger is associated with the open file descriptor. To stop > monitoring, the user only needs to close the file descriptor and the > trigger is discarded. > > Patches 1-6 prepare the psi code for polling support. Patch 7 implements > the adaptive polling logic, the pressure growth detection optimized for > short intervals, and hooks up write() and poll() on the pressure files. > > The patches were developed in collaboration with Johannes Weiner. > > The patches are based on 5.0-rc8 (Merge tag 'drm-next-2019-03-06'). > > Suren Baghdasaryan (7): > psi: introduce state_mask to represent stalled psi states > psi: make psi_enable static > psi: rename psi fields in preparation for psi trigger addition > psi: split update_stats into parts > psi: track changed states > refactor header includes to allow kthread.h inclusion in psi_types.h > psi: introduce psi monitor > > Documentation/accounting/psi.txt | 107 ++++++ > include/linux/kthread.h | 3 +- > include/linux/psi.h | 8 + > include/linux/psi_types.h | 105 +++++- > include/linux/sched.h | 1 - > kernel/cgroup/cgroup.c | 71 +++- > kernel/kthread.c | 1 + > kernel/sched/psi.c | 613 ++++++++++++++++++++++++++++--- > 8 files changed, 833 insertions(+), 76 deletions(-) > > Changes in v5: > - Fixed sparse: error: incompatible types in comparison expression, as per > Andrew > - Changed psi_enable to static, as per Andrew > - Refactored headers to be able to include kthread.h into psi_types.h > without creating a circular inclusion, as per Johannes > - Split psi monitor from aggregator, used RT worker for psi monitoring to > prevent it being starved by other RT threads and memory pressure events > being delayed or lost, as per Minchan and Android Performance Team > - Fixed blockable memory allocation under rcu_read_lock inside > psi_trigger_poll by using refcounting, as per Eva Huang and Minchan > - Misc cleanup and improvements, as per Johannes > > Notes: > 0001-psi-introduce-state_mask-to-represent-stalled-psi-st.patch is unchanged > from the previous version and provided for completeness. Please fix kbuild test bot's warning in 6/7 Other than that, for all patches, Acked-by: Minchan Kim