From: Herbert Xu <herbert@gondor.apana.org.au>
To: NeilBrown <neilb@suse.com>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rhashtable: use cmpxchg() in nested_table_alloc()
Date: Wed, 20 Mar 2019 13:41:09 +0800 [thread overview]
Message-ID: <20190320054109.6abodcm4yyhacc5w@gondor.apana.org.au> (raw)
In-Reply-To: <87lg1gocj8.fsf@notabene.neil.brown.name>
On Fri, Mar 15, 2019 at 05:51:55PM +1100, NeilBrown wrote:
>
> I hoped the patch could be justified on the basis that the current
> behaviour is fragile - the dependency that a single spin lock covers a
> while slot (and all children) in the top-level nested table is not at
> all obvious.
>
> I do have a stronger reason though - I want the replace the spinlocks
> with bit-spin-locks. With those we will only hold a lock for the
> particular chain being worked on. If you need that extra explanation to
> justify the patch, I'll hold it over until the other two patches land
> and the rest of the bit-spin-lock series is ready.
I think it would make more sense to combine this patch with your
bit-spin-lock patch in a series.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-03-20 5:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:05 [PATCH 0/3] Three rhashtable improvements NeilBrown
2019-03-14 5:05 ` [PATCH 3/3] rhashtable: rename rht_for_each*continue as *from NeilBrown
2019-03-15 5:49 ` Herbert Xu
2019-03-17 7:50 ` Miguel Ojeda
2019-03-18 0:15 ` NeilBrown
2019-03-14 5:05 ` [PATCH 2/3] rhashtable: don't hold lock on first table throughout insertion NeilBrown
2019-03-14 14:58 ` Paul E. McKenney
2019-03-15 5:47 ` Herbert Xu
2019-03-15 6:46 ` NeilBrown
2019-03-20 5:40 ` Herbert Xu
2019-03-14 5:05 ` [PATCH 1/3] rhashtable: use cmpxchg() in nested_table_alloc() NeilBrown
2019-03-15 5:10 ` Herbert Xu
2019-03-15 6:51 ` NeilBrown
2019-03-20 5:41 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320054109.6abodcm4yyhacc5w@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).