From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D60CC43381 for ; Thu, 21 Mar 2019 00:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1788D2083D for ; Thu, 21 Mar 2019 00:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="F+wz+KBU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbfCUAe7 (ORCPT ); Wed, 20 Mar 2019 20:34:59 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:37659 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727771AbfCUAew (ORCPT ); Wed, 20 Mar 2019 20:34:52 -0400 Received: by mail-qt1-f195.google.com with SMTP id z16so3412884qtn.4 for ; Wed, 20 Mar 2019 17:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VXwps16vASwoCwctvt+c7hXAgg4xM5xUnznKf8pbr4E=; b=F+wz+KBU6c5XYVr/XcGDyV8lbJqiOM6t2n2UMRjLGYEIzbqDnCXLYtyMgsA1jQ2bQn GgFFejHln14tX5vHSLeCEAW1tHV/ESEx6IoFxdMXP2NMF/jY59mukSwgijpo+z5nJTPk 3qL6iVy/YQQWkqwwADVfoo7cDFIVUbNehoA3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VXwps16vASwoCwctvt+c7hXAgg4xM5xUnznKf8pbr4E=; b=G65mSjAC1UhcvRwN7lxGVEqDCF/77sigQ3b5iH6JVTfsr6w42oMMbJYeD7n1Wsyowe 2c73INlC4zXtkPDYuESVEpJX//ekCBCp/RP50TdGarsw4rp3tQeAKQ9QWs69iiKHPmqy PiBahgcNLo7R6uIiQXC8D1dccLR11frwMSmQ9biweFFP9T7wgzIFYPaXulKVNvDjsOr0 O1TAZYLYBXV0TLtRTpmF3IG6woq4CXCN1uQo0b3er6wc/+YZeezJTeIxMVR5SQCHqzls GxkNdkP7hYBKbeTjrYB841jIG2/ZCTz3/oClAnWKjHJub8e/dXopsE4D7zUrECvMoMU7 Y1bQ== X-Gm-Message-State: APjAAAWPMudBXoQgW66upol+3+zrsB7c3bYNQg4/slWlEll6sHd5epPG +aUJYOPiM1CALh/TlnDIAl8aLarkQnQ= X-Google-Smtp-Source: APXvYqxOrY9pxSJR9LMG73HalrbnXN5RofP5xjcWc9GfONoexUhjKRrzzIdMjcZl5HeL2MvlhfK9NQ== X-Received: by 2002:aed:20e3:: with SMTP id 90mr624928qtb.357.1553128491194; Wed, 20 Mar 2019 17:34:51 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:0:1004:1100:cca9:fccc:8667:9bdc]) by smtp.gmail.com with ESMTPSA id u15sm2908475qth.54.2019.03.20.17.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Mar 2019 17:34:50 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , "Paul E . McKenney" , Ingo Molnar , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, kernel-team@android.com, Lai Jiangshan , Luc Van Oostenryck , Mathieu Desnoyers , Morten Rasmussen , Peter Zijlstra , rcu@vger.kernel.org, Steven Rostedt Subject: [PATCH v2 1/4] sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu Date: Wed, 20 Mar 2019 20:34:23 -0400 Message-Id: <20190321003426.160260-2-joel@joelfernandes.org> X-Mailer: git-send-email 2.21.0.225.g810b269d1ac-goog In-Reply-To: <20190321003426.160260-1-joel@joelfernandes.org> References: <20190321003426.160260-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Recently I added an RCU annotation check to rcu_assign_pointer(). All pointers assigned to RCU protected data are to be annotated with __rcu inorder to be able to use rcu_assign_pointer() similar to checks in other RCU APIs. This resulted in a sparse error: kernel//sched/cpufreq.c:41:9: sparse: error: incompatible types in comparison expression (different address spaces) Fix this by annotating cpufreq_update_util_data pointer with __rcu. This will also help sparse catch any future RCU misuage bugs. [From an RCU perspective] Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- kernel/sched/cpufreq.c | 2 +- kernel/sched/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/cpufreq.c b/kernel/sched/cpufreq.c index 835671f0f917..b5dcd1d83c7f 100644 --- a/kernel/sched/cpufreq.c +++ b/kernel/sched/cpufreq.c @@ -7,7 +7,7 @@ */ #include "sched.h" -DEFINE_PER_CPU(struct update_util_data *, cpufreq_update_util_data); +DEFINE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data); /** * cpufreq_add_update_util_hook - Populate the CPU's update_util_data pointer. diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index efa686eeff26..713715dd00cf 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2185,7 +2185,7 @@ static inline u64 irq_time_read(int cpu) #endif /* CONFIG_IRQ_TIME_ACCOUNTING */ #ifdef CONFIG_CPU_FREQ -DECLARE_PER_CPU(struct update_util_data *, cpufreq_update_util_data); +DECLARE_PER_CPU(struct update_util_data __rcu *, cpufreq_update_util_data); /** * cpufreq_update_util - Take a note about CPU utilization changes. -- 2.21.0.225.g810b269d1ac-goog