From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
tglx@linutronix.de, Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH v3] rcu: Allow to eliminate softirq processing from rcutree
Date: Fri, 22 Mar 2019 00:35:53 -0700 [thread overview]
Message-ID: <20190322073553.GA22086@linux.ibm.com> (raw)
In-Reply-To: <20190321233244.GA11476@linux.ibm.com>
On Thu, Mar 21, 2019 at 04:32:44PM -0700, Paul E. McKenney wrote:
> On Wed, Mar 20, 2019 at 04:46:01PM -0700, Paul E. McKenney wrote:
> > On Wed, Mar 20, 2019 at 10:13:33PM +0100, Sebastian Andrzej Siewior wrote:
> > > Running RCU out of softirq is a problem for some workloads that would
> > > like to manage RCU core processing independently of other softirq
> > > work, for example, setting kthread priority. This commit therefore
> > > introduces the `rcunosoftirq' option which moves the RCU core work
> > > from softirq to a per-CPU/per-flavor SCHED_OTHER kthread named rcuc.
> > > The SCHED_OTHER approach avoids the scalability problems that appeared
> > > with the earlier attempt to move RCU core processing to from softirq
> > > to kthreads. That said, kernels built with RCU_BOOST=y will run the
> > > rcuc kthreads at the RCU-boosting priority.
> > >
> > > Reported-by: Thomas Gleixner <tglx@linutronix.de>
> > > Tested-by: Mike Galbraith <efault@gmx.de>
> > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >
> > Thank you! I reverted v2 and applied this one with the same sort of
> > update. Testing is going well thus far aside from my failing to add
> > the required "=0" after the rcutree.use_softirq. I will probably not
> > be the only one who will run afoul of this, so I updated the commit log
> > and the documentation accordingly, as shown below.
>
> And I took a look, please see updates/questions interspersed.
>
> I didn't find anything substantive, but still I get hangs. Which is
> the normal situation. ;-)
>
> Will fire off more testing...
And despite my protestations about restrictions involving the scheduler
and rcu_read_unlock(), with the patch below TREE01, TREE02, TREE03, and
TREE09 pass an hour of rcutorture with rcutree.use_softirq=0. Without
this patch, seven-minute runs get hard hangs and this:
[ 18.417315] BUG: spinlock recursion on CPU#5, rcu_torture_rea/763
[ 18.418624] lock: 0xffff9d207eb61940, .magic: dead4ead, .owner: rcu_torture_rea/763, .owner_cpu: 5
[ 18.420418] CPU: 5 PID: 763 Comm: rcu_torture_rea Not tainted 5.1.0-rc1+ #1
[ 18.421786] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
[ 18.423375] Call Trace:
[ 18.423880] <IRQ>
[ 18.424284] dump_stack+0x46/0x5b
[ 18.424953] do_raw_spin_lock+0x8d/0x90
[ 18.425699] try_to_wake_up+0x2cd/0x4f0
[ 18.426493] invoke_rcu_core_kthread+0x63/0x80
[ 18.427337] rcu_read_unlock_special+0x41/0x80
[ 18.428212] __rcu_read_unlock+0x48/0x50
[ 18.428984] cpuacct_charge+0x96/0xd0
[ 18.429725] ? cpuacct_charge+0x2e/0xd0
[ 18.430463] update_curr+0x112/0x240
[ 18.431172] enqueue_task_fair+0xa9/0x1220
[ 18.432009] ttwu_do_activate+0x49/0xa0
[ 18.432741] sched_ttwu_pending+0x75/0xa0
[ 18.433583] scheduler_ipi+0x53/0x150
[ 18.434291] reschedule_interrupt+0xf/0x20
[ 18.435137] </IRQ
I clearly need to audit the setting of ->rcu_read_unlock_special.
Again, the patch below is bad for expedited grace periods, so it is
experimental.
Thanx, Paul
------------------------------------------------------------------------
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index ca972b0b2467..d133fa837426 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -607,12 +607,9 @@ static void rcu_read_unlock_special(struct task_struct *t)
if (preempt_bh_were_disabled || irqs_were_disabled) {
WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, false);
/* Need to defer quiescent state until everything is enabled. */
- if (irqs_were_disabled) {
+ if (irqs_were_disabled && use_softirq) {
/* Enabling irqs does not reschedule, so... */
- if (use_softirq)
- raise_softirq_irqoff(RCU_SOFTIRQ);
- else
- invoke_rcu_core();
+ raise_softirq_irqoff(RCU_SOFTIRQ);
} else {
/* Enabling BH or preempt does reschedule, so... */
set_tsk_need_resched(current);
next prev parent reply other threads:[~2019-03-22 14:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 11:11 [PATCH] rcu: Allow to eliminate softirq processing from rcutree Sebastian Andrzej Siewior
2019-03-15 13:35 ` Steven Rostedt
2019-03-15 13:57 ` Sebastian Andrzej Siewior
2019-03-18 2:24 ` Paul E. McKenney
2019-03-19 11:44 ` [PATCH v2] " Sebastian Andrzej Siewior
2019-03-19 15:59 ` Paul E. McKenney
2019-03-19 16:24 ` Sebastian Andrzej Siewior
2019-03-19 16:50 ` Paul E. McKenney
2019-03-19 17:02 ` Sebastian Andrzej Siewior
2019-03-20 11:32 ` Sebastian Andrzej Siewior
2019-03-20 15:21 ` Paul E. McKenney
2019-03-20 15:44 ` Paul E. McKenney
2019-03-20 16:05 ` Sebastian Andrzej Siewior
2019-03-20 16:15 ` Paul E. McKenney
2019-03-20 16:35 ` Sebastian Andrzej Siewior
2019-03-20 17:30 ` Paul E. McKenney
2019-03-20 17:59 ` Sebastian Andrzej Siewior
2019-03-20 18:12 ` Paul E. McKenney
2019-03-20 18:14 ` Sebastian Andrzej Siewior
2019-03-20 21:13 ` [PATCH v3] " Sebastian Andrzej Siewior
2019-03-20 23:46 ` Paul E. McKenney
2019-03-21 8:27 ` Sebastian Andrzej Siewior
2019-03-21 13:26 ` Paul E. McKenney
2019-03-21 23:32 ` Paul E. McKenney
2019-03-22 7:35 ` Paul E. McKenney [this message]
2019-03-22 12:43 ` Paul E. McKenney
2019-03-22 13:42 ` Joel Fernandes
2019-03-22 14:58 ` Paul E. McKenney
2019-03-22 15:50 ` Joel Fernandes
2019-03-22 16:26 ` Paul E. McKenney
2019-03-22 18:07 ` Paul E. McKenney
2019-03-22 23:48 ` Joel Fernandes
2019-03-23 0:25 ` Paul E. McKenney
2019-03-23 1:04 ` Joel Fernandes
2019-03-23 16:10 ` Paul E. McKenney
2019-03-24 23:42 ` Paul E. McKenney
2019-03-25 13:41 ` Joel Fernandes
2019-03-25 15:08 ` Paul E. McKenney
2019-03-25 15:52 ` Paul E. McKenney
2019-03-20 0:26 ` [PATCH] " Joel Fernandes
2019-03-20 11:28 ` Sebastian Andrzej Siewior
2019-03-21 12:06 ` Joel Fernandes
2019-03-21 13:52 ` Paul E. McKenney
2019-03-20 15:24 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322073553.GA22086@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).